build: drop macro used to enable -Wsign-conversion warnings in CI#16157
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
build: drop macro used to enable -Wsign-conversion warnings in CI#16157vszakats wants to merge 1 commit intocurl:masterfrom
-Wsign-conversion warnings in CI#16157vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
We don't pursue this, and the necessary `#pragma` got in the way of compiling curl with gcc 4.2 and older. Drop the logic completely. Follow-up to 8a266ac curl#15939 Reported-by: prpr19xx on Github Fixes curl#16152
f3b26f6 to
fb3dead
Compare
Member
Author
|
That done, it'd be nice to have the ability to override/tweak picky warnings with custom CFLAGS. This doesn't seem possible with either CMake or autotools. |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
We don't pursue this, and the necessary `#pragma` got in the way of compiling curl with gcc 4.2 and older. Drop the logic completely. Follow-up to 8a266ac curl#15939 Reported-by: prpr19xx on Github Fixes curl#16152 Closes curl#16157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't pursue this, and the necessary
#pragmagot in the way ofcompiling curl with gcc 4.2 and older. Drop the logic completely.
Follow-up to 8a266ac #15939
Reported-by: prpr19xx on Github
Fixes #16152