build: delete -Wsign-conversion related FIXMEs#15939
Closed
vszakats wants to merge 4 commits intocurl:masterfrom
Closed
build: delete -Wsign-conversion related FIXMEs#15939vszakats wants to merge 4 commits intocurl:masterfrom
-Wsign-conversion related FIXMEs#15939vszakats wants to merge 4 commits intocurl:masterfrom
Conversation
-Wsign-conversion globally, drop FIXMEs
Member
Author
|
Hm, giving this another go (this was a patch set aside in a backlog) to just delete the |
afdcd46 to
d39a646
Compare
-Wsign-conversion globally, drop FIXMEs-Wsign-conversion related FIXMEs
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 3, 2025
We don't pursue this, and the necessary `#pragma` got in the way of compiling curl with gcc 4.2 and older. Drop the logic completely. Follow-up to 8a266ac curl#15939 Reported-by: prpr19xx on Github
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 3, 2025
We don't pursue this, and the necessary `#pragma` got in the way of compiling curl with gcc 4.2 and older. Drop the logic completely. Follow-up to 8a266ac curl#15939 Reported-by: prpr19xx on Github Fixes curl#16152
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 3, 2025
We don't pursue this, and the necessary `#pragma` got in the way of compiling curl with gcc 4.2 and older. Drop the logic completely. Follow-up to 8a266ac curl#15939 Reported-by: prpr19xx on Github Fixes curl#16152
vszakats
added a commit
that referenced
this pull request
Feb 3, 2025
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
We decided last year not to pursue avoiding this warning, because it adds noise and friction, while in most cases not revealing actual code issues. We fixed the interesting portion of them throughout mid-2024. Conclude this effort by deleting related FIXMEs and temporary comments. Follow-up to 3829759 curl#12489 Closes curl#15939
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
We don't pursue this, and the necessary `#pragma` got in the way of compiling curl with gcc 4.2 and older. Drop the logic completely. Follow-up to 8a266ac curl#15939 Reported-by: prpr19xx on Github Fixes curl#16152 Closes curl#16157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We decided last year not to pursue avoiding this warning, because it
adds noise and friction, while in most cases not revealing actual code
issues. We fixed the interesting portion of them throughout mid-2024.
Conclude this effort by deleting related FIXMEs and temporary comments.
Follow-up to 3829759 #12489