cmake: drop LDAP_DEPRECATED=1 macro, to sync with autotools#16146
Closed
vszakats wants to merge 4 commits intocurl:masterfrom
Closed
cmake: drop LDAP_DEPRECATED=1 macro, to sync with autotools#16146vszakats wants to merge 4 commits intocurl:masterfrom
LDAP_DEPRECATED=1 macro, to sync with autotools#16146vszakats wants to merge 4 commits intocurl:masterfrom
Conversation
`lib/ldap.c` sets this macro in source for non-OpenLDAP with all build systems. Follow-up to 751e168 curl#12024
This reverts commit be33bb6. It does, but the warning no longer shows since switching to -isystem. That's why autotools did not need it.
This comment was marked as outdated.
This comment was marked as outdated.
LDAP_DEPRECATED=1 macro to sync with autotoolsLDAP_DEPRECATED=1 macro, to sync with autotools
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
We set this macro to silence a warning inside `openldap.h`. With this warning now silenced by using `-isystem`, we can drop it. Also it never had to be set to `1`. Also enable OpenLDAP in a CMake GHA/macos job. Follow-up to 445fb81 curl#14763 Follow-up to 751e168 curl#12024 Closes curl#16146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We set this macro to silence a warning inside
openldap.h. With thiswarning now silenced by using
-isystem, we can drop it. Also it neverhad to be set to
1.Also enable OpenLDAP in a CMake GHA/macos job.
Follow-up to 445fb81 #14763
Follow-up to 751e168 #12024