Closed
Conversation
To avoid warnings like this: ``` /usr/local/opt/openldap/include/ldap.h:1049:5: warning: 'LDAP_DEPRECATED' is not defined, evaluates to 0 [-Wundef] ``` autotools also does this.
c338923 to
a4ff364
Compare
ligurio
added a commit
to ligurio/nanodata
that referenced
this pull request
Dec 22, 2023
The commit 751e168d93b4a58f3fbbe2908c0041ae2f934329 ("cmake: improve
OpenLDAP builds") [1][2] in Curl deletes CMake option CURL_USE_OPENLDAP.
The patch relects this change in Tarantool's build infrastructure.
1. curl/curl@751e168
2. curl/curl#12024
Follows up tarantool#9086
NO_CHANGELOG=third_party
NO_DOC=third_party
NO_TEST=third_party
ligurio
added a commit
to ligurio/nanodata
that referenced
this pull request
Dec 22, 2023
The commit 751e168d93b4a58f3fbbe2908c0041ae2f934329 ("cmake: improve
OpenLDAP builds") [1][2] in Curl deletes CMake option CURL_USE_OPENLDAP.
The patch relects this change in Tarantool's build infrastructure.
1. curl/curl@751e168
2. curl/curl#12024
Follows up tarantool#9086
NO_CHANGELOG=third_party
NO_DOC=third_party
NO_TEST=third_party
ligurio
added a commit
to ligurio/nanodata
that referenced
this pull request
Dec 26, 2023
The commit 751e168d93b4a58f3fbbe2908c0041ae2f934329 ("cmake: improve
OpenLDAP builds") [1][2] in Curl deletes CMake option CURL_USE_OPENLDAP.
The patch relects this change in Tarantool's build infrastructure.
1. curl/curl@751e168
2. curl/curl#12024
Follows up tarantool#9086
NO_CHANGELOG=third_party
NO_DOC=third_party
NO_TEST=third_party
ligurio
added a commit
to ligurio/nanodata
that referenced
this pull request
Dec 26, 2023
The commit "cmake: improve OpenLDAP builds" [1][2] in Curl deletes CMake option CURL_USE_OPENLDAP. The patch relects this change in Tarantool's build infrastructure. 1. curl/curl@751e168 2. curl/curl#12024 Follows up tarantool#9086 NO_CHANGELOG=third_party NO_DOC=third_party NO_TEST=third_party
ligurio
added a commit
to ligurio/nanodata
that referenced
this pull request
Dec 26, 2023
The commit "cmake: improve OpenLDAP builds" [1][2] in Curl deletes CMake option CURL_USE_OPENLDAP. The patch reflects this change in Tarantool's build infrastructure. 1. curl/curl@751e168 2. curl/curl#12024 Follows up tarantool#9086 NO_CHANGELOG=third_party NO_DOC=third_party NO_TEST=third_party
igormunkin
pushed a commit
to tarantool/tarantool
that referenced
this pull request
Dec 27, 2023
The commit "cmake: improve OpenLDAP builds" [1][2] in Curl deletes CMake option CURL_USE_OPENLDAP. The patch reflects this change in Tarantool's build infrastructure. 1. curl/curl@751e168 2. curl/curl#12024 Follows up #9086 NO_CHANGELOG=third_party NO_DOC=third_party NO_TEST=third_party
ligurio
added a commit
to ligurio/nanodata
that referenced
this pull request
Jan 9, 2024
The commit "cmake: improve OpenLDAP builds" [1][2] in Curl deletes CMake option CURL_USE_OPENLDAP. The patch reflects this change in Tarantool's build infrastructure. 1. curl/curl@751e168 2. curl/curl#12024 Follows up tarantool#9086 NO_CHANGELOG=third_party NO_DOC=third_party NO_TEST=third_party (cherry picked from commit 7e3dc17)
ligurio
added a commit
to ligurio/nanodata
that referenced
this pull request
Jan 9, 2024
The commit "cmake: improve OpenLDAP builds" [1][2] in Curl deletes CMake option CURL_USE_OPENLDAP. The patch reflects this change in Tarantool's build infrastructure. 1. curl/curl@751e168 2. curl/curl#12024 Follows up tarantool#9086 NO_CHANGELOG=third_party NO_DOC=third_party NO_TEST=third_party (cherry picked from commit 7e3dc17)
igormunkin
pushed a commit
to tarantool/tarantool
that referenced
this pull request
Jan 10, 2024
The commit "cmake: improve OpenLDAP builds" [1][2] in Curl deletes CMake option CURL_USE_OPENLDAP. The patch reflects this change in Tarantool's build infrastructure. 1. curl/curl@751e168 2. curl/curl#12024 Follows up #9086 NO_CHANGELOG=third_party NO_DOC=third_party NO_TEST=third_party (cherry picked from commit 7e3dc17)
igormunkin
pushed a commit
to tarantool/tarantool
that referenced
this pull request
Jan 10, 2024
The commit "cmake: improve OpenLDAP builds" [1][2] in Curl deletes CMake option CURL_USE_OPENLDAP. The patch reflects this change in Tarantool's build infrastructure. 1. curl/curl@751e168 2. curl/curl#12024 Follows up #9086 NO_CHANGELOG=third_party NO_DOC=third_party NO_TEST=third_party (cherry picked from commit 7e3dc17)
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 1, 2025
`lib/ldap.c` sets this macro in source for non-OpenLDAP with all build systems. Follow-up to 751e168 curl#12024
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
We set this macro to silence a warning inside `openldap.h`. With this warning now silenced by using `-isystem`, we can drop it. Also it never had to be set to `1`. Also enable OpenLDAP in a CMake GHA/macos job. Follow-up to 445fb81 curl#14763 Follow-up to 751e168 curl#12024 Closes curl#16146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmake: detect OpenLDAP based on function
ldap_init_fd.autotools does this. autotools also publishes this detection result
in
HAVE_LDAP_INIT_FD. We don't mimic that with CMake as the sourcedoesn't use this value. (it might need to be remove-listed in
scripts/cmp-config.plfor future OpenLDAP test builds.)This also deletes existing self-declaration method via the
CMake-specific
CURL_USE_OPENLDAPconfiguration.cmake: define
LDAP_DEPRECATED=1for OpenLDAP.Like autotools does. This fixes a long list of these warnings:
cmake: delete LDAP TODO comment no longer relevant.
Also:
dummywith0.0.0.0in LDAP featuredetection functions.
Ref: #11964 (effort to sync cmake detections with autotools)
Closes #12024