cmake: replace unset(VAR) with set(VAR "") for init#15497
Closed
vszakats wants to merge 3 commits intocurl:masterfrom
Closed
cmake: replace unset(VAR) with set(VAR "") for init#15497vszakats wants to merge 3 commits intocurl:masterfrom
unset(VAR) with set(VAR "") for init#15497vszakats wants to merge 3 commits intocurl:masterfrom
Conversation
Member
Author
|
@dg0yt How does this look to you? |
d1afc04 to
2e085d8
Compare
Contributor
|
@dg0yt Is this effect vcpkg? Do you think it better? |
2e085d8 to
d487e9c
Compare
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Also add cleanup `unset()`s where missing. Reported-by: Kai Pastor Bug: curl#15255 (comment) Follow-up to 8b09138 curl#14610 Closes curl#15497
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add cleanup
unset()s where missing.Reported-by: Kai Pastor
Bug: #15255 (comment)
Follow-up to 8b09138 #14610