Closed
Conversation
d0a8655 to
ae8b2fd
Compare
4aada7f to
7c51a6f
Compare
8e367b8 to
820e5ac
Compare
58faa00 to
f8952dc
Compare
git grep -E '[^ ][ ]{2,}[^ #]' | grep -i cmake
They are equivalent, the first one expressing the intent more unambiguously. https://cmake.org/cmake/help/latest/command/set.html
f8952dc to
0b69765
Compare
Without status the output goes to stderr, and goes red in CMake GUI. This was not intended, the goal was to align these lines exactly with the curl -V output to make it easy to compare visually. This doesn't seem doable with CMake. Partial revert of acbc6b7 curl#14197
3c0551f to
ffcf3c7
Compare
Leave the logic there to keep code in sync between tests. They inflated the generated make code by 600KB. (seen with GNU Makefiles) Ref: a2ef5d3 curl#14660
13 tasks
vszakats
added a commit
that referenced
this pull request
Dec 16, 2024
Also add cleanup `unset()`s where missing. Reported-by: Kai Pastor Bug: #15255 (comment) Follow-up to 8b09138 #14610 Closes #15497
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Also add cleanup `unset()`s where missing. Reported-by: Kai Pastor Bug: curl#15255 (comment) Follow-up to 8b09138 curl#14610 Closes curl#15497
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL v3+when detected (as in./configure).(this string also makes its way to
curl-config.)unset(VAR)overset(VAR).Same effect, but
unset()tells the intent unambiguously.https://cmake.org/cmake/help/latest/command/set.html
option()description.https://cmake.org/cmake/help/latest/command/get_filename_component.html
CURL_STATIC_CRTlogic next to itsoption().libcurl.pc/curl-configvariable init lines.They inflated generated make files by 550KB.
Keep target name logic for sync between code snippets.
Follow-up to a2ef5d3 cmake: sync code between test/example targets #14660
STATUSforFeatures:/Protocols:message()s:Without it the output goes to stderr, and appears in red in CMake GUI.
It doesn't seem possible to show a line on stdout without leading
underscores to match
curl -Vand./configureoutput.Partial revert of acbc6b7 cmake: tidy-ups #14197
HAVE_LINUX_TCP_Hinto the header group.STRINGkeyword.