cmake: fix cached SET vars with CURL_CA_BUNDLE/CURL_CA_PATH set to none#14778
Closed
vszakats wants to merge 2 commits intocurl:masterfrom
Closed
cmake: fix cached SET vars with CURL_CA_BUNDLE/CURL_CA_PATH set to none#14778vszakats wants to merge 2 commits intocurl:masterfrom
SET vars with CURL_CA_BUNDLE/CURL_CA_PATH set to none#14778vszakats wants to merge 2 commits intocurl:masterfrom
Conversation
CURL_CA_*_SET variables in cacheCURL_CA_{BUNDLE|PAT}_SET variables in cache
CURL_CA_{BUNDLE|PAT}_SET variables in cacheCURL_CA_BUNDLE_SET/CURL_CA_PATH_SET variables in cache
Partial revert of c2889a7 curl#14388
Reported-by: Chang-Ning Tsai Fixes curl#6313 (KNOWN_BUGS 15.11)
66e102c to
2888522
Compare
Member
Author
|
Untested. |
CURL_CA_BUNDLE_SET/CURL_CA_PATH_SET variables in cacheSET vars with CURL_CA_BUNDLE/CURL_CA_PATH set to none
Member
Author
|
Abandoning this effort for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 6a9489d #1461Ref: #6313edit: I cannot reproduce the referenced issue. Also the suggested fix doesn't make a difference in the generated
config.handCMakeCache.txtwhen running the repro setup.edit2: The options seems to behave unexpectedly, but it may be my lack of understanding of caching and the ideas around how this should work. I expected the
CURL_CA_BUNDLEandCURL_CA_PATHsettings to "stick" between cmake invocations. They don't. On each run they spring back to "auto". Meanwhile other options (e.g.ENABLE_UNIX_SOCKETS) retain their previously set values.edit3: It seems a 3rd variable would be necessary to cache the builder's intent in all cases. For now, e.g.
nonecannot stick around because its unsetsCURL_CA_BUNDLE, which triggers a reset even after guarding the option initialization with aNOT DEFINED. (or store this information in the_SETvar maybe?)