Closed
Conversation
5b04ad3 to
4864867
Compare
4864867 to
b59483d
Compare
9de0d76 to
1d4ca74
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Aug 16, 2024
`pkg_check_modules()` logs a line when there is a hit, and also warnings if a sub-dependency is missing. In `QUIET` mode, both are completely silent. The extra info is useful to see if a detection happened via `pkg-config`. Keep `pkg_search_module()` in `FindGSS`. We pass two dependencies there and we want to keep stopping on the first one. Partially reverts c2889a7 curl#14388
vszakats
added a commit
that referenced
this pull request
Aug 16, 2024
Prefer `pkg_check_modules()` over `pkg_search_module()`. `pkg_check_modules()` logs a line when there is a hit, and also warnings if a sub-dependency is missing. In `QUIET` mode, both are silent. The extra info is useful to see if a detection happened via `pkg-config`. Keep `pkg_search_module()` in `FindGSS`. We pass two dependencies there and we want to keep stopping on the first one. Partially reverts c2889a7 #14388 Closes #14573
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Sep 4, 2024
Partial revert of c2889a7 curl#14388
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quote string literals.
In the hope it improves syntax-highlighting and readability.
use lowercase, underscore-prefixed local var names.
As a hint for scope, to help readability.
prefer
pkg_search_module(overpkg_check_modules).They are the same, but
pkg_search_modulestops searchingat the first hit.
more
IN LISTSinforeach().OtherTests.cmake: clear
CMAKE_EXTRA_INCLUDE_FILESafter use.add
PROJECT_LABELfor http/client and unit test targets.sync
Find*module comments and formatting.drop a few local variables.
drop bogus
CARES_LIBRARIESfrom comment.unquote numeric literal.
Follow-up to acbc6b7 #14197
Closes #14388