src: silence -Wsign-conversion, type tidy-ups#13470
Closed
vszakats wants to merge 9 commits intocurl:masterfrom
Closed
src: silence -Wsign-conversion, type tidy-ups#13470vszakats wants to merge 9 commits intocurl:masterfrom
-Wsign-conversion, type tidy-ups#13470vszakats wants to merge 9 commits intocurl:masterfrom
Conversation
Member
Author
|
quiche / quiche has been consistently failing for the last few days; it's unrelated to this. |
Member
|
The quiche issue: #13439 |
``` tool_getparam.c:2904:37: error: implicit conversion changes signedness: 'ParameterError' to 'int' [-Werror,-Wsign-conversion] ``` Ref: https://github.com/curl/curl/actions/runs/8861448063/job/24333320546?pr=13489#step:10:1257
-Wsign-conversion-Wsign-conversion, type tidy-ups
Member
Author
|
Closing in favour of #13501 and cherry-picking from there. It has the same commits as this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src(curl tool) building without signedness warnings after this PR.Also:
get_terminal_columns().Cherry-picked from #13489
Follow-up to 3829759 #12489
Closes #13470