examples: fix/silence -Wsign-conversion#13501
Closed
vszakats wants to merge 4 commits intocurl:masterfrom
Closed
Conversation
-Wsign-conversion-Wsign-conversion
Member
Author
|
If no objections I'd go along merging this. It has legitimate fixes and there is only one sign cast. This one, if undesired, can be deleted or beefed up with sign checks. It's used |
This was referenced May 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extend
FD_SET()hack to all platforms (was only Cygwin).Warnings may also happen in other envs, e.g. OmniOS.
Ref: https://github.com/libssh2/libssh2/actions/runs/8854199687/job/24316762831#step:3:2021
tidy-up
CURLcodevsintuse.cast an unsigned to
longbefore passing tocurl_easy_setopt().Cherry-picked from #13489
Follow-up to 3829759 #12489
Closes #13501