Skip to content

tests: silence -Wsign-conversion, type tidy-ups#13469

Closed
vszakats wants to merge 12 commits intocurl:masterfrom
vszakats:signwarn-03
Closed

tests: silence -Wsign-conversion, type tidy-ups#13469
vszakats wants to merge 12 commits intocurl:masterfrom
vszakats:signwarn-03

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Apr 24, 2024

Silence and fix sign conversion issues and compiler warnings
in tests. Also switch all unit tests to return CURLcode. Before
this patch all unit tests and about a third of libtests did this.

Also fix mask signedness and/or types in some printf calls.

Ref: #13467
Cherry-picked from #13489
Follow-up to 3829759 #12489
Closes #13469

@vszakats

This comment was marked as duplicate.

@vszakats vszakats force-pushed the signwarn-03 branch 2 times, most recently from 6b5ddd6 to 15623fd Compare April 27, 2024 11:35
@vszakats vszakats marked this pull request as draft April 29, 2024 15:18
@vszakats vszakats changed the title tests: silence -Wsign-conversion tests: silence -Wsign-conversion, type tidy-ups Apr 29, 2024
@vszakats vszakats marked this pull request as ready for review April 29, 2024 16:29
@vszakats
Copy link
Member Author

Closing in favour of #13501 and cherry-picking from there. It has the same commits as this one.

@vszakats vszakats closed this May 12, 2024
@vszakats vszakats deleted the signwarn-03 branch May 15, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant