cmake: speed up curldown processing, enable by default#12762
Closed
vszakats wants to merge 3 commits intocurl:masterfrom
Closed
cmake: speed up curldown processing, enable by default#12762vszakats wants to merge 3 commits intocurl:masterfrom
vszakats wants to merge 3 commits intocurl:masterfrom
Conversation
bagder
reviewed
Jan 23, 2024
Syncing this with autotools.
f081055 to
9ffdc54
Compare
Member
Author
|
Please double-check my broken Perl-fu. |
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 27, 2024
This time limit the number of files per command to avoid exceeding limitations of certain OS/shell envs. Such known env is Windows with the `cmd.exe` shell, which features an 8K limit to this day. Allowlisting `UNIX` to have no limit and using a limit of 200 for other envs to be safe. If there is a way to detect `cmd.exe` and/or we know which precise envs are sensitive to this, we can tweak these conditions further. Even with the low limit, this patch reduces external commands by 200x, making builds much faster. Ref: curl#13047 Ref: curl#12762 2620aa9 Closes #xxxxx
vszakats
added a commit
that referenced
this pull request
Apr 4, 2024
This time limit the number of files per command to avoid exceeding limitations of certain OS/shell envs. Such known env is Windows with the `cmd.exe` shell, which features an 8K command-line length limit to this day. Allowlisting `UNIX` to have no limit and using a limit of 200 for other envs to be safe. If there is a way to detect `cmd.exe` and/or we know which precise envs are sensitive to this, we can tweak these conditions further. Even with the low limit, this patch reduces external commands by 200x, making builds much faster. Ref: #12762 2620aa9 (initial) Ref: #13047 f03c856 (revert) Reviewed-by: Daniel Stenberg Closes #13207
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmake: enable
BUILD_DOCSby default (this controls converting andinstalling
.3files from.mdsources)cmake: speed up generating
.3files by using a single command perdirectory, instead of a single command per file. This reduces external
commands by about a thousand. (There remains some CMake logic kicking
in resulting in 500 -one per file- external
-E touch_nocreatecalls.)cd2nroff: add ability to process multiple input files.
cd2nroff: add
-koption to use the source filename to form theoutput filename. (instead of the default in-file
Title:line.)Follow-up to 3f08d80
Follow-up to ea0b575 #12753
Follow-up to eefcc1b #12730
Closes #12762