Skip to content

Modify appropriate CMakeLists.txts to use curldown#12753

Merged
bagder merged 1 commit intocurl:bagder/curldownfrom
levitte:bagder/curldown
Jan 22, 2024
Merged

Modify appropriate CMakeLists.txts to use curldown#12753
bagder merged 1 commit intocurl:bagder/curldownfrom
levitte:bagder/curldown

Conversation

@levitte
Copy link
Contributor

@levitte levitte commented Jan 22, 2024

This throws away the previous HTML and PDF producers, to mimic what
Makefile.am does as faithfully as possible. They can easily be added
back if that's desirable.

Amends #12730

@github-actions github-actions bot added the CI Continuous Integration label Jan 22, 2024
@levitte
Copy link
Contributor Author

levitte commented Jan 22, 2024

Currently in draft... I wanna see what happens in appveyor (I think I still have that enabled)

@levitte
Copy link
Contributor Author

levitte commented Jan 22, 2024

close/open dance to kick appveyor into gear

@levitte levitte closed this Jan 22, 2024
@levitte levitte reopened this Jan 22, 2024
@levitte
Copy link
Contributor Author

levitte commented Jan 22, 2024

Nope... apparently, my appveyor-fu is too weak to get it running. Oh bother.

@levitte levitte marked this pull request as ready for review January 22, 2024 07:19
@vszakats vszakats added the cmake label Jan 22, 2024
@bagder
Copy link
Member

bagder commented Jan 22, 2024

Lovely, many thanks. Trying it out now!

@levitte
Copy link
Contributor Author

levitte commented Jan 22, 2024

@bagder, I just added installation instructions as well, you might want to try them out

@levitte
Copy link
Contributor Author

levitte commented Jan 22, 2024

Hold on, the install instructions aren't quite right

@levitte
Copy link
Contributor Author

levitte commented Jan 22, 2024

Now they're done right.

@levitte
Copy link
Contributor Author

levitte commented Jan 22, 2024

... and some cleaning up. Hadn't noticed the "disappeared" commits that this PR carried around

@bagder bagder merged commit d0af6c2 into curl:bagder/curldown Jan 22, 2024
bagder pushed a commit that referenced this pull request Jan 22, 2024
This throws away the previous HTML and PDF producers, to mimic what
Makefile.am does as faithfully as possible.

Closes #12753
vszakats added a commit that referenced this pull request Jan 23, 2024
- cmake: enable `BUILD_DOCS` by default (this controls converting and
  installing `.3` files from `.md` sources)

- cmake: speed up generating `.3` files by using a single command per
  directory, instead of a single command per file. This reduces external
  commands by about a thousand. (There remains some CMake logic kicking
  in resulting in 500 -one per file- external `-E touch_nocreate` calls.)

- cd2nroff: add ability to process multiple input files.

- cd2nroff: add `-k` option to use the source filename to form the
  output filename. (instead of the default in-file `Title:` line.)

Follow-up to 3f08d80
Follow-up to ea0b575 #12753
Follow-up to eefcc1b #12730

Closes #12762
vszakats added a commit that referenced this pull request Nov 24, 2025
Also:
- delete `roffit`, that's not used anymore.
  Follow-up to ea0b575 #12753

Follow-up to 92d9dbe #19611

Closes #19677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants