Problem: (CRO-495) no way for client to unjail account by leejw51crypto · Pull Request #503 · crypto-com/thaler

leejw51crypto · 2019-10-22T08:56:59Z

add unjail-tx to default network client

fix un-covered match

fix un-covered match in wallet-rpc

fix argument

add unit test

rename

tomtau

unjailtx isn't obfuscated -- it shouldn't be sent to the tx-query enclave. it can be constructed locally and can be verified directly in chain-abci

leejw51 · 2019-10-22T09:01:22Z

ok

devashishdxt

Besides the changes discussed, can you add a test-case where transaction creation is successful?

leejw51 · 2019-10-22T09:23:09Z

ok, i will add it

codecov · 2019-10-22T09:36:20Z

Codecov Report

Merging #503 into master will increase coverage by 0.13%.
The diff coverage is 89.85%.

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
+ Coverage   67.08%   67.22%   +0.13%     
==========================================
  Files         120      120              
  Lines       14051    14114      +63     
==========================================
+ Hits         9426     9488      +62     
- Misses       4625     4626       +1

Impacted Files	Coverage Δ
client-common/src/transaction.rs	`48.64% <ø> (+2.49%)`	⬆️
client-rpc/src/rpc/wallet_rpc.rs	`73.5% <ø> (ø)`	⬆️
client-core/src/cipher/default.rs	`0% <ø> (ø)`	⬆️
...re/src/cipher/mock_abci_transaction_obfuscation.rs	`69.36% <ø> (+1.22%)`	⬆️
...work/src/network_ops/default_network_ops_client.rs	`87.03% <89.85%> (+0.58%)`	⬆️

tomtau

a small formatting of the commit message, there should be a line + Solution::

Problem: (CRO-495) no way for client to unjail account

Solution: ...

client-network/src/network_ops/default_network_ops_client.rs

client-core/src/cipher/default.rs

Solution: add unjail tx to nework ops client add unjail-tx to default network client fix un-covered match fix un-covered match in wallet-rpc fix argument add unit test rename remove unjail for enclave protocol add unit test tidy up remove un-used codes

tomtau

next would be to expose this functionality in client-cli and client-rpc

tomtau · 2019-10-23T03:06:34Z

bors r+

503: Problem: (CRO-495) no way for client to unjail account r=tomtau a=leejw51crypto add unjail-tx to default network client fix un-covered match fix un-covered match in wallet-rpc fix argument add unit test rename Co-authored-by: Jongwhan Lee <jonghwan@crypto.com>

490: Bump jsonrpc-derive from 14.0.0 to 14.0.1 r=tomtau a=dependabot-preview[bot] Bumps [jsonrpc-derive](https://github.com/paritytech/jsonrpc) from 14.0.0 to 14.0.1. <details> <summary>Commits</summary> - [`b4635c5`](paritytech/jsonrpc@b4635c5) Bump version. ([crypto-com#509](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/509)) - [`3fc22d1`](paritytech/jsonrpc@3fc22d1) Update syn & co ([crypto-com#507](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/507)) - [`d1993a8`](paritytech/jsonrpc@d1993a8) Fix race condition on `wait()` ([crypto-com#504](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/504)) - [`8ebb62d`](paritytech/jsonrpc@8ebb62d) Disable travis & appveyor. ([crypto-com#506](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/506)) - [`1f11075`](paritytech/jsonrpc@1f11075) Integrate gitlab ci ([crypto-com#503](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/503)) - [`d3d8c6b`](paritytech/jsonrpc@d3d8c6b) ignore dropped connections ([crypto-com#502](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/502)) - [`4418476`](paritytech/jsonrpc@4418476) Make sure RpcEventLoop is Send+Sync ([crypto-com#499](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/499)) - [`cc8f26d`](paritytech/jsonrpc@cc8f26d) Solve compiler error when serde is not a dependency of user project ([crypto-com#481](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/481)) (#... - See full diff in [compare view](paritytech/jsonrpc@v14.0.0...v14.0.1) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=jsonrpc-derive&package-manager=cargo&previous-version=14.0.0&new-version=14.0.1)](https://dependabot.com/compatibility-score.html?dependency-name=jsonrpc-derive&package-manager=cargo&previous-version=14.0.0&new-version=14.0.1) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

491: Bump jsonrpc-core-client from 14.0.0 to 14.0.1 r=tomtau a=dependabot-preview[bot] Bumps [jsonrpc-core-client](https://github.com/paritytech/jsonrpc) from 14.0.0 to 14.0.1. <details> <summary>Commits</summary> - [`b4635c5`](paritytech/jsonrpc@b4635c5) Bump version. ([crypto-com#509](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/509)) - [`3fc22d1`](paritytech/jsonrpc@3fc22d1) Update syn & co ([crypto-com#507](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/507)) - [`d1993a8`](paritytech/jsonrpc@d1993a8) Fix race condition on `wait()` ([crypto-com#504](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/504)) - [`8ebb62d`](paritytech/jsonrpc@8ebb62d) Disable travis & appveyor. ([crypto-com#506](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/506)) - [`1f11075`](paritytech/jsonrpc@1f11075) Integrate gitlab ci ([crypto-com#503](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/503)) - [`d3d8c6b`](paritytech/jsonrpc@d3d8c6b) ignore dropped connections ([crypto-com#502](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/502)) - [`4418476`](paritytech/jsonrpc@4418476) Make sure RpcEventLoop is Send+Sync ([crypto-com#499](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/499)) - [`cc8f26d`](paritytech/jsonrpc@cc8f26d) Solve compiler error when serde is not a dependency of user project ([crypto-com#481](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/481)) (#... - See full diff in [compare view](paritytech/jsonrpc@v14.0.0...v14.0.1) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=jsonrpc-core-client&package-manager=cargo&previous-version=14.0.0&new-version=14.0.1)](https://dependabot.com/compatibility-score.html?dependency-name=jsonrpc-core-client&package-manager=cargo&previous-version=14.0.0&new-version=14.0.1) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

bors · 2019-10-23T03:54:17Z

Build succeeded

tomtau requested review from calvinaco, devashishdxt, lezzokafka and tomtau and removed request for devashishdxt and tomtau October 22, 2019 08:57

tomtau suggested changes Oct 22, 2019

View reviewed changes

devashishdxt suggested changes Oct 22, 2019

View reviewed changes

leejw51crypto force-pushed the cro-495 branch from 171cf2c to 24ee299 Compare October 22, 2019 09:24

tomtau suggested changes Oct 22, 2019

View reviewed changes

client-network/src/network_ops/default_network_ops_client.rs Outdated Show resolved Hide resolved

leejw51crypto force-pushed the cro-495 branch 3 times, most recently from 41ed3cd to f5eaab1 Compare October 22, 2019 10:29

tomtau reviewed Oct 22, 2019

View reviewed changes

client-core/src/cipher/default.rs Outdated Show resolved Hide resolved

leejw51crypto force-pushed the cro-495 branch from f5eaab1 to 21ccb0a Compare October 23, 2019 02:58

devashishdxt approved these changes Oct 23, 2019

View reviewed changes

tomtau self-requested a review October 23, 2019 03:05

tomtau approved these changes Oct 23, 2019

View reviewed changes

bors bot merged commit 21ccb0a into crypto-com:master Oct 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Problem: (CRO-495) no way for client to unjail account#503

Problem: (CRO-495) no way for client to unjail account#503
bors[bot] merged 1 commit intocrypto-com:masterfrom
leejw51crypto:cro-495

leejw51crypto commented Oct 22, 2019

Uh oh!

tomtau left a comment

Uh oh!

leejw51 commented Oct 22, 2019

Uh oh!

devashishdxt left a comment

Uh oh!

leejw51 commented Oct 22, 2019

Uh oh!

codecov bot commented Oct 22, 2019 •

edited

Loading

Uh oh!

tomtau left a comment

Uh oh!

Uh oh!

Uh oh!

tomtau left a comment

Uh oh!

tomtau commented Oct 23, 2019

Uh oh!

bors bot commented Oct 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

leejw51crypto commented Oct 22, 2019

Uh oh!

tomtau left a comment

Choose a reason for hiding this comment

Uh oh!

leejw51 commented Oct 22, 2019

Uh oh!

devashishdxt left a comment

Choose a reason for hiding this comment

Uh oh!

leejw51 commented Oct 22, 2019

Uh oh!

codecov bot commented Oct 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tomtau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tomtau left a comment

Choose a reason for hiding this comment

Uh oh!

tomtau commented Oct 23, 2019

Uh oh!

bors bot commented Oct 23, 2019

Build succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Oct 22, 2019 •

edited

Loading