Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: paritytech/jsonrpc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v14.0.0
Choose a base ref
...
head repository: paritytech/jsonrpc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v14.0.1
Choose a head ref
  • 8 commits
  • 46 files changed
  • 5 contributors

Commits on Oct 10, 2019

  1. Solve compiler error when serde is not a dependency of user project (#…

    …481) (#498)
    
    Use `serde` directly instead of ask for user of the library to add it as a
    dependency.
    
    Tests are modified since this is a ui change.
    
    The doc comment gives an example using `#[rpc(server)]` instead of original
    `#[rpc]`, telling users that this attribute has an option to be used to
    configure it.
    simeir4 authored and tomusdrw committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    cc8f26d View commit details
    Browse the repository at this point in the history
  2. Make sure RpcEventLoop is Send+Sync (#499)

    * Add Send + Sync test.
    
    * Add test to make sure the tpc server is Send+Sync too.
    
    * Review suggestions.
    
    * Make sure to use latest tokio version.
    tomusdrw authored Oct 10, 2019
    Configuration menu
    Copy the full SHA
    4418476 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. ignore dropped connections (#502)

    * ignore dropped connections
    
    * bump version, warn instead of trace
    seunlanlege authored and niklasad1 committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    d3d8c6b View commit details
    Browse the repository at this point in the history
  2. Integrate gitlab ci (#503)

    * added giltab-ci
    
    * removed '--lock' from test
    
    * no time command in onw windows
    
    * added stage: checkstyle
    
    * shortend the config a bit
    
    * bit more compact ci-file
    
    * gitlab-ci intergation
    
    * changed order of ci jobs
    
    * Re-format.
    fevo1971 authored and tomusdrw committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    1f11075 View commit details
    Browse the repository at this point in the history
  3. Disable travis & appveyor. (#506)

    * Disable travis & appveyor.
    
    * Fix fmt.
    tomusdrw authored Oct 16, 2019
    Configuration menu
    Copy the full SHA
    8ebb62d View commit details
    Browse the repository at this point in the history
  4. Fix race condition on wait() (#504)

    Manually dropping the future passed from `Future::select` before sending
    `done_tx` prevents the race condition.
    
    `Future::select` pass the unresolved future, which is a `Server` holding
    `rpc_handler`, to the following callback. Therefore, it is dropped after
    the `done_tx.send(())` after the callback exits.
    It is possible that the thread that has executed `wait()`, which is
    usually the main thread, terminates before the thread sending `done_tx`
    drops `rpc_handler`.
    Static variables are destructed at the end of termination of the main
    thread, and then a segfault occurs when the thread dropping the
    rpc_handler accesses the variables.
    foriequal0 authored and tomusdrw committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    d1993a8 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. Update syn & co (#507)

    * Update syn, quote & proc-macro2
    
    * Apply review suggestions.
    
    * Re-format.
    tomusdrw authored Oct 18, 2019
    Configuration menu
    Copy the full SHA
    3fc22d1 View commit details
    Browse the repository at this point in the history
  2. Bump version. (#509)

    tomusdrw authored and dvdplm committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    b4635c5 View commit details
    Browse the repository at this point in the history
Loading