-
Notifications
You must be signed in to change notification settings - Fork 267
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: paritytech/jsonrpc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v14.0.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: paritytech/jsonrpc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v14.0.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 8 commits
- 46 files changed
- 5 contributors
Commits on Oct 10, 2019
-
Solve compiler error when serde is not a dependency of user project (#…
…481) (#498) Use `serde` directly instead of ask for user of the library to add it as a dependency. Tests are modified since this is a ui change. The doc comment gives an example using `#[rpc(server)]` instead of original `#[rpc]`, telling users that this attribute has an option to be used to configure it.
Configuration menu - View commit details
-
Copy full SHA for cc8f26d - Browse repository at this point
Copy the full SHA cc8f26dView commit details -
Make sure RpcEventLoop is Send+Sync (#499)
* Add Send + Sync test. * Add test to make sure the tpc server is Send+Sync too. * Review suggestions. * Make sure to use latest tokio version.
Configuration menu - View commit details
-
Copy full SHA for 4418476 - Browse repository at this point
Copy the full SHA 4418476View commit details
Commits on Oct 16, 2019
-
ignore dropped connections (#502)
* ignore dropped connections * bump version, warn instead of trace
Configuration menu - View commit details
-
Copy full SHA for d3d8c6b - Browse repository at this point
Copy the full SHA d3d8c6bView commit details -
* added giltab-ci * removed '--lock' from test * no time command in onw windows * added stage: checkstyle * shortend the config a bit * bit more compact ci-file * gitlab-ci intergation * changed order of ci jobs * Re-format.
Configuration menu - View commit details
-
Copy full SHA for 1f11075 - Browse repository at this point
Copy the full SHA 1f11075View commit details -
Disable travis & appveyor. (#506)
* Disable travis & appveyor. * Fix fmt.
Configuration menu - View commit details
-
Copy full SHA for 8ebb62d - Browse repository at this point
Copy the full SHA 8ebb62dView commit details -
Fix race condition on
wait()(#504)Manually dropping the future passed from `Future::select` before sending `done_tx` prevents the race condition. `Future::select` pass the unresolved future, which is a `Server` holding `rpc_handler`, to the following callback. Therefore, it is dropped after the `done_tx.send(())` after the callback exits. It is possible that the thread that has executed `wait()`, which is usually the main thread, terminates before the thread sending `done_tx` drops `rpc_handler`. Static variables are destructed at the end of termination of the main thread, and then a segfault occurs when the thread dropping the rpc_handler accesses the variables.
Configuration menu - View commit details
-
Copy full SHA for d1993a8 - Browse repository at this point
Copy the full SHA d1993a8View commit details
Commits on Oct 18, 2019
-
* Update syn, quote & proc-macro2 * Apply review suggestions. * Re-format.
Configuration menu - View commit details
-
Copy full SHA for 3fc22d1 - Browse repository at this point
Copy the full SHA 3fc22d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4635c5 - Browse repository at this point
Copy the full SHA b4635c5View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v14.0.0...v14.0.1