This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Problem: (CRO-127) No support for simple schnorr signatures for 1-of-n transactions#117
Merged
tomtau merged 1 commit intocrypto-com:masterfrom Jun 3, 2019
devashishdxt:1-of-n
Merged
Problem: (CRO-127) No support for simple schnorr signatures for 1-of-n transactions#117tomtau merged 1 commit intocrypto-com:masterfrom devashishdxt:1-of-n
tomtau merged 1 commit intocrypto-com:masterfrom
devashishdxt:1-of-n
Conversation
…n transactions Solution: Added support for simple schnorr signatures for 1-of-n transactions
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
========================================
+ Coverage 80.84% 81% +0.15%
========================================
Files 71 71
Lines 6255 6306 +51
========================================
+ Hits 5057 5108 +51
Misses 1198 1198
|
tomtau
reviewed
Jun 3, 2019
Contributor
tomtau
left a comment
There was a problem hiding this comment.
@devashishdxt looks good -- just a question: the multi-sig isn't integrated with transaction builder parts yet, right?
For 1-of-n, it should fit with what's there more or less (depending on the unspent output's type, one would either call sign or schnorr_sign+ generate inclusion proof)
Contributor
Author
@tomtau Yes. We should be able to integrate current transaction builder with 1-of-n schnorr signatures. I’ll take that up next. |
tomtau
approved these changes
Jun 3, 2019
bors bot
added a commit
that referenced
this pull request
Oct 28, 2019
524: Bump base64 from 0.10.1 to 0.11.0 r=tomtau a=dependabot-preview[bot] Bumps [base64](https://github.com/marshallpierce/rust-base64) from 0.10.1 to 0.11.0. <details> <summary>Changelog</summary> *Sourced from [base64's changelog](https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md).* > - 0.11.0 > - Minimum rust version 1.34.0 > - `no_std` is now supported via the two new features `alloc` and `std`. </details> <details> <summary>Commits</summary> - [`edc3859`](marshallpierce/rust-base64@edc3859) v0.11.0 - [`07b1d6b`](marshallpierce/rust-base64@07b1d6b) Merge pull request [#117](https://github-redirect.dependabot.com/marshallpierce/rust-base64/issues/117) from eclipseo/patch-1 - [`e923d5f`](marshallpierce/rust-base64@e923d5f) Bump criterion to 0.3 - [`9ae0292`](marshallpierce/rust-base64@9ae0292) Merge pull request [#116](https://github-redirect.dependabot.com/marshallpierce/rust-base64/issues/116) from Shnatsel/patch-1 - [`85623ca`](marshallpierce/rust-base64@85623ca) Advertise that unsafe code is forbidden - [`a40d420`](marshallpierce/rust-base64@a40d420) Merge pull request [#111](https://github-redirect.dependabot.com/marshallpierce/rust-base64/issues/111) from CryZe/no-std - [`b4da176`](marshallpierce/rust-base64@b4da176) Write Documentation and add CI for no_std - [`3e0fe90`](marshallpierce/rust-base64@3e0fe90) Bump Minimum Version to 1.34.0 - [`6d44a63`](marshallpierce/rust-base64@6d44a63) Implement Support for no_std - [`d4cd64f`](marshallpierce/rust-base64@d4cd64f) Merge pull request [#114](https://github-redirect.dependabot.com/marshallpierce/rust-base64/issues/114) from marshallpierce/forbid-unsafe - Additional commits viewable in [compare view](marshallpierce/rust-base64@v0.10.1...v0.11.0) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=base64&package-manager=cargo&previous-version=0.10.1&new-version=0.11.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> 525: Bump serde from 1.0.101 to 1.0.102 r=tomtau a=dependabot-preview[bot] Bumps [serde](https://github.com/serde-rs/serde) from 1.0.101 to 1.0.102. <details> <summary>Release notes</summary> *Sourced from [serde's releases](https://github.com/serde-rs/serde/releases).* > ## v1.0.102 > - Support deserializing `PathBuf` from bytes like `&Path` already did, and support deserializing `Box<Path>` ([#1656](https://github-redirect.dependabot.com/serde-rs/serde/issues/1656), thanks [@​heftig](https://github.com/heftig)) </details> <details> <summary>Commits</summary> - [`2ceabad`](serde-rs/serde@2ceabad) Release 1.0.102 - [`a00aee1`](serde-rs/serde@a00aee1) Use a dedicated cfg for PathBuf::into_boxed_path - [`4e31c99`](serde-rs/serde@4e31c99) Merge pull request [#1656](https://github-redirect.dependabot.com/serde-rs/serde/issues/1656) from heftig/path-improvements - [`b8772a1`](serde-rs/serde@b8772a1) Deserialize Box\<Path> through PathBuf::into_boxed_path - [`42990d8`](serde-rs/serde@42990d8) Deserialize PathBuf from bytes - [`cf31418`](serde-rs/serde@cf31418) Resolve unused_self lint - [`5db72b8`](serde-rs/serde@5db72b8) Ignore must_use_candidate pedantic lint - [`fe8f8bc`](serde-rs/serde@fe8f8bc) Address needless_doctest_main lint in serde_test - [`d4d737d`](serde-rs/serde@d4d737d) Resolve redundant_clone lint - [`52f6e96`](serde-rs/serde@52f6e96) Ignore needless_doctest_main lint - Additional commits viewable in [compare view](serde-rs/serde@v1.0.101...v1.0.102) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=serde&package-manager=cargo&previous-version=1.0.101&new-version=1.0.102) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Added support for simple schnorr signatures for 1-of-n transactions
This change is