Skip to content
This repository was archived by the owner on Jul 27, 2022. It is now read-only.

Problem: (Fix#1533) Error messages is ambiguous for node-join/unbond Txs #1656

Merged
bors[bot] merged 1 commit intocrypto-com:masterfrom
lezzokafka:1533
May 25, 2020
Merged

Problem: (Fix#1533) Error messages is ambiguous for node-join/unbond Txs #1656
bors[bot] merged 1 commit intocrypto-com:masterfrom
lezzokafka:1533

Conversation

@lezzokafka
Copy link
Copy Markdown
Collaborator

@lezzokafka lezzokafka commented May 25, 2020

Solution:

  • Update the error message.

@devashishdxt
Copy link
Copy Markdown
Contributor

devashishdxt commented May 25, 2020

bors r+

@devashishdxt
Copy link
Copy Markdown
Contributor

devashishdxt commented May 25, 2020

bors r-

bors Bot added a commit that referenced this pull request May 25, 2020
@bors @lezzokafka
Merge #1656
fecce01 
1656: Problem: (Fix#1533) Error messages is ambiguous for node-join/unbond Txs  r=devashishdxt a=lezzokafka

Solution:
- Update the error message.

Co-authored-by: Leslie Cheung <51898510+lezzokafka@users.noreply.github.com>
@bors
Copy link
Copy Markdown
Contributor

bors Bot commented May 25, 2020

Canceled.

devashishdxt
devashishdxt suggested changes May 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@devashishdxt devashishdxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the commit message to:

Problem: ...

Solution: ...

devashishdxt
devashishdxt approved these changes May 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@devashishdxt devashishdxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors Bot added a commit that referenced this pull request May 25, 2020
@bors @lezzokafka
Merge #1656
1776302 
1656: Problem: (Fix#1533) Error messages is ambiguous for node-join/unbond Txs  r=devashishdxt a=lezzokafka

Solution:
- Update the error message.

Co-authored-by: Leslie Cheung <51898510+lezzokafka@users.noreply.github.com>
@bors
Copy link
Copy Markdown
Contributor

bors Bot commented May 25, 2020

Build failed:

@devashishdxt
Copy link
Copy Markdown
Contributor

devashishdxt commented May 25, 2020

bors retry

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2020 •
edited
Loading

Codecov Report

Merging #1656 into master will increase coverage by 1.58%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1656      +/-   ##
==========================================
+ Coverage   67.75%   69.34%   +1.58%     
==========================================
  Files         188      179       -9     
  Lines       22806    21430    -1376     
==========================================
- Hits        15453    14860     -593     
+ Misses       7353     6570     -783
Impacted Files Coverage Δ
client-core/src/service/wallet_service.rs 80.97% <100.00%> (-8.41%) ⬇️
client-core/src/wallet.rs 0.00% <0.00%> (-100.00%) ⬇️
client-core/src/input_selection.rs 0.00% <0.00%> (-70.00%) ⬇️
client-core/src/wallet/default_wallet_client.rs 39.38% <0.00%> (-9.90%) ⬇️
client-core/src/mnemonic.rs 93.75% <0.00%> (-3.13%) ⬇️
client-common/src/error.rs 64.78% <0.00%> (-1.41%) ⬇️
chain-core/src/common/merkle_tree.rs 97.81% <0.00%> (-0.22%) ⬇️
client-core/src/cipher/default.rs 0.00% <0.00%> (ø)
client-rpc/src/lib.rs
... and 18 more

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented May 25, 2020

Build succeeded:

@bors bors Bot merged commit 1fc5976 into crypto-com:master May 25, 2020
@lezzokafka lezzokafka mentioned this pull request May 27, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner

@tomtau tomtau Awaiting requested review from tomtau

1 more reviewer

@devashishdxt devashishdxt devashishdxt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lezzokafka @devashishdxt