portable classes: implementation#786
Merged
negz merged 3 commits intocrossplane:masterfrom Sep 12, 2019
Merged
Conversation
Collaborator
|
|
4 tasks
negz
requested changes
Sep 12, 2019
Member
negz
left a comment
There was a problem hiding this comment.
Looks good! This will be ready to merge when:
- It's rebased after the AWS deletion work.
- The CRUD related changes are in a separate commit.
- We've addressed the potential panic in the SetPortableClassItems methods.
47fd497 to
e943e05
Compare
Collaborator
|
|
negz
reviewed
Sep 12, 2019
Collaborator
|
|
negz
approved these changes
Sep 12, 2019
Member
|
Approved, but added a do not merge warning until the AWS stuff is sorted out. :) |
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
36826f4 to
756a221
Compare
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Implements portable classes following merge of crossplane/crossplane-runtime#13.
Ready to merge following #788!
Partially fixes #723 and #703
Checklist
I have:
make reviewableto ensure this PR is ready for review.clusterrole.yamlto include any new types.