Merged
Conversation
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
negz
requested changes
Sep 11, 2019
Member
negz
left a comment
There was a problem hiding this comment.
Thanks for starting on this! I like this emergent pattern of making a smaller change here in crossplane-runtime that we can then propagate to the other projects in smaller PRs.
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
negz
requested changes
Sep 12, 2019
Member
negz
left a comment
There was a problem hiding this comment.
Almost ready to merge; just a few minor comments to address.
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
negz
approved these changes
Sep 12, 2019
This was referenced Sep 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR is the first step in implementing the design proposed in crossplane/crossplane#743. It refactors the shared default class reconciler and claim reconciler. Updates will need to be applied to each of the provider stacks as well core crossplane.
This is a partial fix for crossplane/crossplane#703 and crossplane/crossplane#723.
The following changes will need to be applied following merge of this PR:
ClassKindsinstead of justClasscrossplane-runtimedependency versionPolicykinds toClasskinds and make sure they embedPortableClasstype and satisfyPortableClassinterfaceDefaultClassControllersto passPortableClassKindinstead ofPolicyKindChecklist
I have:
make reviewableto ensure this PR is ready for review.clusterrole.yamlto include any new types.