Skip to content

Remove AWS code from repo and use AWS stack going forward#788

Merged
jbw976 merged 3 commits intocrossplane:masterfrom
jbw976:remove-aws
Sep 12, 2019
Merged

Remove AWS code from repo and use AWS stack going forward#788
jbw976 merged 3 commits intocrossplane:masterfrom
jbw976:remove-aws

Conversation

@jbw976
Copy link
Copy Markdown
Member

@jbw976 jbw976 commented Sep 12, 2019

Description of your changes

This PR removes all AWS code from the repo and adds instructions for how to use the new AWS stack. The stack-aws repo now has an official CI build on Jenkins, so new versions of the stack are being automatically built and published.

Checklist

I have:

  • Run make reviewable to ensure this PR is ready for review.
  • Ensured this PR contains a neat, self documenting set of commits.
  • Updated any relevant documentation, examples, or release notes.
  • Updated the RBAC permissions in clusterrole.yaml to include any new types.

Copy link
Copy Markdown
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soorena776 soorena776 self-requested a review September 12, 2019 22:47
@soorena776
Copy link
Copy Markdown

LGTM

@upbound-bot
Copy link
Copy Markdown
Collaborator

77% (+7.87%) vs master 69%

@jbw976 jbw976 merged commit b4b2f47 into crossplane:master Sep 12, 2019
@jbw976 jbw976 deleted the remove-aws branch September 12, 2019 23:02
@hasheddan hasheddan mentioned this pull request Sep 12, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants