OCPBUGS-82142: [release-1.34] oci: wait for exit file before defaulting to exit code 255 by openshift-cherrypick-robot · Pull Request #9879 · cri-o/cri-o

openshift-cherrypick-robot · 2026-04-13T16:04:04Z

This is an automated cherry-pick of #9871

/assign openshift-cherrypick-robot

Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.

/cherrypick release-1.33

When a container exits very quickly, the OCI runtime may clean up its state before CRI-O queries it. In this case, runtimeCmd("state") fails and CRI-O falls back to reading the exit file. However, conmon may not have written the exit file yet, causing CRI-O to immediately default to exit code 255 with no retry. Extract the existing exponential backoff wait for the exit file into a shared waitForExitFile() function and use it in both code paths: - Path A: when runtimeCmd("state") fails and the exit file is missing - Path B: when runtimeCmd("state") reports the container as stopped This ensures fast-exiting containers get the correct exit code from conmon's exit file instead of a spurious 255. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Ayato Tokubi <atokubi@redhat.com>

openshift-ci-robot · 2026-04-13T16:04:08Z

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-82162 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle [release-1.34] : : oci: wait for exit file before defaulting to exit code 255

Details

In response to this:

This is an automated cherry-pick of #9871

/assign openshift-cherrypick-robot
Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.
/cherrypick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-04-13T16:04:12Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7aa99ef2-6089-42ca-9f72-c67015af2045

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-04-13T16:04:16Z

@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-82162, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-82162 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle [release-1.34] : : oci: wait for exit file before defaulting to exit code 255
In response to this:
This is an automated cherry-pick of #9871

/assign openshift-cherrypick-robot
Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.
/cherrypick release-1.33
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-04-13T16:04:20Z

@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

This is an automated cherry-pick of #9871

/assign openshift-cherrypick-robot
Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.
/cherrypick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov · 2026-04-13T19:57:29Z

Codecov Report

❌ Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.86%. Comparing base (dd7d093) to head (dad7101).
⚠️ Report is 14 commits behind head on release-1.34.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-1.34    #9879       +/-   ##
=================================================
+ Coverage         46.91%   64.86%   +17.95%     
=================================================
  Files               164      204       +40     
  Lines             25138    28853     +3715     
=================================================
+ Hits              11793    18716     +6923     
+ Misses            12183     8509     -3674     
- Partials           1162     1628      +466

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

openshift-ci-robot · 2026-04-14T08:01:50Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-82142, which is invalid:

expected dependent Jira Issue OCPBUGS-82162 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #9871

/assign openshift-cherrypick-robot
Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.
/cherrypick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-04-20T04:32:36Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-82142. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

This is an automated cherry-pick of #9871

/assign openshift-cherrypick-robot
Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.
/cherrypick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-04-20T04:32:41Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-82142, which is valid. The bug has been moved to the POST state.

5 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-82162 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #9871

/assign openshift-cherrypick-robot
Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.
/cherrypick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bitoku · 2026-04-27T07:49:28Z

/retest

bitoku · 2026-04-28T14:27:48Z

/retest

bitoku · 2026-04-29T02:24:27Z

/retest

bitoku · 2026-04-30T07:49:59Z

/lgtm
@cri-o/cri-o-maintainers PTAL

bitoku · 2026-05-05T04:51:04Z

@cri-o/cri-o-maintainers PTAL

haircommander · 2026-05-06T16:36:52Z

/approve

openshift-ci · 2026-05-06T16:37:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [haircommander]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-05-06T19:44:53Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-82142: All pull requests linked via external trackers have merged:

cri-o/cri-o#9879

Jira Issue OCPBUGS-82142 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #9871

/assign openshift-cherrypick-robot
Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.
/cherrypick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-05-06T19:45:48Z

@openshift-cherrypick-robot: new pull request created: #9932

Details

In response to this:

This is an automated cherry-pick of #9871

/assign openshift-cherrypick-robot
Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.
/cherrypick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot requested a review from mrunalp as a code owner April 13, 2026 16:04

openshift-cherrypick-robot mentioned this pull request Apr 13, 2026

OCPBUGS-82162: [release-1.35] : oci: wait for exit file before defaulting to exit code 255 #9871

Merged

openshift-ci Bot assigned openshift-cherrypick-robot Apr 13, 2026

openshift-ci Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 13, 2026

openshift-ci Bot requested review from hasan4791 and littlejawa April 13, 2026 16:04

openshift-ci Bot changed the title ~~[release-1.34] OCPBUGS-82162: : oci: wait for exit file before defaulting to exit code 255~~ [release-1.34] : : oci: wait for exit file before defaulting to exit code 255 Apr 13, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 13, 2026

openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 13, 2026

bitoku changed the title ~~[release-1.34] : : oci: wait for exit file before defaulting to exit code 255~~ OCPBUGS-82142: [release-1.34] oci: wait for exit file before defaulting to exit code 255 Apr 14, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 14, 2026

bitoku closed this Apr 20, 2026

bitoku reopened this Apr 20, 2026

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 20, 2026

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 20, 2026

bitoku self-assigned this Apr 28, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2026

openshift-merge-bot Bot merged commit 91b4b0b into cri-o:release-1.34 May 6, 2026
84 of 101 checks passed

openshift-cherrypick-robot mentioned this pull request May 6, 2026

[release-1.33] OCPBUGS-82143: oci: wait for exit file before defaulting to exit code 255 #9932

Merged

Conversation

openshift-cherrypick-robot commented Apr 13, 2026

Uh oh!

openshift-ci-robot commented Apr 13, 2026

Uh oh!

coderabbitai Bot commented Apr 13, 2026

Review skipped

Uh oh!

openshift-ci-robot commented Apr 13, 2026

Uh oh!

openshift-ci-robot commented Apr 13, 2026

Uh oh!

codecov Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

openshift-ci-robot commented Apr 14, 2026

Uh oh!

openshift-ci-robot commented Apr 20, 2026

Uh oh!

openshift-ci-robot commented Apr 20, 2026

Uh oh!

bitoku commented Apr 27, 2026

Uh oh!

bitoku commented Apr 28, 2026

Uh oh!

bitoku commented Apr 29, 2026

Uh oh!

bitoku commented Apr 30, 2026

Uh oh!

bitoku commented May 5, 2026

Uh oh!

haircommander commented May 6, 2026

Uh oh!

openshift-ci Bot commented May 6, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented May 6, 2026

Uh oh!

openshift-cherrypick-robot commented May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Apr 13, 2026 •

edited

Loading