OCPBUGS-82162: [release-1.35] : oci: wait for exit file before defaulting to exit code 255 by openshift-cherrypick-robot · Pull Request #9871 · cri-o/cri-o

openshift-cherrypick-robot · 2026-04-08T15:37:10Z

This is an automated cherry-pick of #9846

/assign bitoku

Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.

/cherrypick release-1.34 release-1.33

coderabbitai · 2026-04-08T15:37:25Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1861a688-7364-42bc-9c6f-3d435b89b072

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-04-08T15:38:09Z

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-81547 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle [release-1.35] : oci: wait for exit file before defaulting to exit code 255

Details

In response to this:

This is an automated cherry-pick of #9846

/assign bitoku
Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.
/cherrypick release-1.34 release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-04-08T15:38:25Z

@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-81547, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-81547 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-81547 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle [release-1.35] : oci: wait for exit file before defaulting to exit code 255
In response to this:
This is an automated cherry-pick of #9846

/assign bitoku
Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.
/cherrypick release-1.34 release-1.33
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-04-08T15:38:27Z

@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

This is an automated cherry-pick of #9846

/assign bitoku
Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.
/cherrypick release-1.34 release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bitoku · 2026-04-08T15:54:06Z

/jira refresh

bitoku · 2026-04-08T15:54:15Z

/retest

openshift-ci-robot · 2026-04-08T15:54:16Z

@bitoku: This pull request references Jira Issue OCPBUGS-81547, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-81547 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-04-08T15:59:09Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-82162, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-82162 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #9846

/assign bitoku
Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.
/cherrypick release-1.34 release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bitoku · 2026-04-08T15:59:09Z

/jira refresh

openshift-ci-robot · 2026-04-08T15:59:14Z

@bitoku: This pull request references Jira Issue OCPBUGS-82162, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-82162 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bitoku · 2026-04-08T16:03:57Z

/refresh

bitoku · 2026-04-08T16:04:33Z

/jira refresh

openshift-ci-robot · 2026-04-08T16:04:39Z

@bitoku: This pull request references Jira Issue OCPBUGS-82162, which is invalid:

expected dependent Jira Issue OCPBUGS-82142 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

When a container exits very quickly, the OCI runtime may clean up its state before CRI-O queries it. In this case, runtimeCmd("state") fails and CRI-O falls back to reading the exit file. However, conmon may not have written the exit file yet, causing CRI-O to immediately default to exit code 255 with no retry. Extract the existing exponential backoff wait for the exit file into a shared waitForExitFile() function and use it in both code paths: - Path A: when runtimeCmd("state") fails and the exit file is missing - Path B: when runtimeCmd("state") reports the container as stopped This ensures fast-exiting containers get the correct exit code from conmon's exit file instead of a spurious 255. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Ayato Tokubi <atokubi@redhat.com>

bitoku · 2026-04-08T16:11:48Z

/jira refresh

openshift-ci-robot · 2026-04-08T16:11:56Z

@bitoku: This pull request references Jira Issue OCPBUGS-82162, which is valid. The bug has been moved to the POST state.

5 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-81547 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov · 2026-04-08T19:57:34Z

Codecov Report

❌ Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.62%. Comparing base (fb90456) to head (ba41d0e).
⚠️ Report is 2 commits behind head on release-1.35.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-1.35    #9871      +/-   ##
================================================
- Coverage         67.74%   67.62%   -0.12%     
================================================
  Files               211      211              
  Lines             29294    29307      +13     
================================================
- Hits              19845    19820      -25     
- Misses             7766     7804      +38     
  Partials           1683     1683

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

haircommander · 2026-04-10T19:29:20Z

/lgtm
/approve

openshift-ci · 2026-04-10T19:29:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [haircommander]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bitoku · 2026-04-13T12:30:21Z

/retest

openshift-ci-robot · 2026-04-13T16:03:25Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-82162: All pull requests linked via external trackers have merged:

cri-o/cri-o#9871

Jira Issue OCPBUGS-82162 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #9846

/assign bitoku
Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.
/cherrypick release-1.34 release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-04-13T16:04:05Z

@openshift-cherrypick-robot: new pull request created: #9879

Details

In response to this:

This is an automated cherry-pick of #9846

/assign bitoku
Fixed the race condition where cri-o reports exitCode 255 when the container exits fast.
/cherrypick release-1.34 release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot requested a review from mrunalp as a code owner April 8, 2026 15:37

openshift-cherrypick-robot mentioned this pull request Apr 8, 2026

OCPBUGS-81547: oci: wait for exit file before defaulting to exit code 255 #9846

Merged

openshift-ci Bot assigned bitoku Apr 8, 2026

openshift-ci Bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 8, 2026

openshift-ci Bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 8, 2026

openshift-ci Bot requested review from QiWang19 and klihub April 8, 2026 15:38

openshift-ci Bot changed the title ~~[release-1.35] OCPBUGS-81547: oci: wait for exit file before defaulting to exit code 255~~ [release-1.35] : oci: wait for exit file before defaulting to exit code 255 Apr 8, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 8, 2026

openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 8, 2026

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 8, 2026

bitoku changed the title ~~[release-1.35] : oci: wait for exit file before defaulting to exit code 255~~ OCPBUGS-81547: [release-1.35] : oci: wait for exit file before defaulting to exit code 255 Apr 8, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 8, 2026

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 8, 2026

bitoku changed the title ~~OCPBUGS-81547: [release-1.35] : oci: wait for exit file before defaulting to exit code 255~~ OCPBUGS-82162: [release-1.35] : oci: wait for exit file before defaulting to exit code 255 Apr 8, 2026

bitoku force-pushed the cherry-pick-9846-to-release-1.35 branch from 0cfa388 to ba41d0e Compare April 8, 2026 16:08

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 8, 2026

openshift-ci Bot assigned haircommander Apr 10, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2026

openshift-merge-bot Bot merged commit 6e7047d into cri-o:release-1.35 Apr 13, 2026
48 of 51 checks passed

openshift-cherrypick-robot mentioned this pull request Apr 13, 2026

OCPBUGS-82142: [release-1.34] oci: wait for exit file before defaulting to exit code 255 #9879

Merged

Conversation

openshift-cherrypick-robot commented Apr 8, 2026

Uh oh!

coderabbitai Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci-robot commented Apr 8, 2026

Uh oh!

openshift-ci-robot commented Apr 8, 2026

Uh oh!

openshift-ci-robot commented Apr 8, 2026

Uh oh!

bitoku commented Apr 8, 2026

Uh oh!

bitoku commented Apr 8, 2026

Uh oh!

openshift-ci-robot commented Apr 8, 2026

Uh oh!

openshift-ci-robot commented Apr 8, 2026

Uh oh!

bitoku commented Apr 8, 2026

Uh oh!

openshift-ci-robot commented Apr 8, 2026

Uh oh!

bitoku commented Apr 8, 2026

Uh oh!

bitoku commented Apr 8, 2026

Uh oh!

openshift-ci-robot commented Apr 8, 2026

Uh oh!

bitoku commented Apr 8, 2026

Uh oh!

openshift-ci-robot commented Apr 8, 2026

Uh oh!

codecov Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

haircommander commented Apr 10, 2026

Uh oh!

openshift-ci Bot commented Apr 10, 2026

Uh oh!

bitoku commented Apr 13, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 13, 2026

Uh oh!

openshift-cherrypick-robot commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai Bot commented Apr 8, 2026 •

edited

Loading

codecov Bot commented Apr 8, 2026 •

edited

Loading