Skip to content

Add tests and simple implementation for the interval overload for expand#1554

Merged
JPercival merged 2 commits intofeature-expand-intervalfrom
feature-expand-interval-tests-and-simple-implementation
May 16, 2025
Merged

Add tests and simple implementation for the interval overload for expand#1554
JPercival merged 2 commits intofeature-expand-intervalfrom
feature-expand-interval-tests-and-simple-implementation

Conversation

@antvaset
Copy link
Copy Markdown
Contributor

  • Added XML tests for the interval overload for the expand operator and the edge cases. Tried to reuse existing tests for the list overload as much as possible to get the expected outputs right.
  • Changed the implementation of the interval overload to directly follow the spec.
  • Narrowed down the list of failing tests that needed to be skipped.

Next steps:

  • Review the implementation of the list overload. The corresponding tests for the interval overload will pass once the list overload is implemented fully according to spec.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 16, 2025

Formatting check succeeded!

@codecov
Copy link
Copy Markdown

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature-expand-interval@365762e). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             feature-expand-interval    #1554   +/-   ##
==========================================================
  Coverage                           ?   64.67%           
  Complexity                         ?     1965           
==========================================================
  Files                              ?      496           
  Lines                              ?    28357           
  Branches                           ?     5612           
==========================================================
  Hits                               ?    18341           
  Misses                             ?     7740           
  Partials                           ?     2276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
76.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JPercival JPercival merged commit fd2b661 into feature-expand-interval May 16, 2025
6 of 7 checks passed
@JPercival JPercival deleted the feature-expand-interval-tests-and-simple-implementation branch May 16, 2025 17:13
JPercival added a commit that referenced this pull request Jun 10, 2025
* WIP Interval override for expand

* Add tests and simple implementation for the interval overload for `expand` (#1554)

* Add tests and simple implementation

* Fix animal sniffer

* Improved implementation of the `expand` operator

* Improved implementation of the `expand` operator

* Sync with master

* Unskip expand test

* Add `else if`

* Fix comment

* Fix comment

* check Decimal ranges

* Add comment

* Many improvements

* Many improvements

* Use different timezone in test

---------

Co-authored-by: Jonathan Percival <jonathan.i.percival@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants