Skip to content

Improved implementation of the expand operator#1556

Merged
JPercival merged 18 commits intomasterfrom
feature-expand-interval-improved-implementation
Jun 10, 2025
Merged

Improved implementation of the expand operator#1556
JPercival merged 18 commits intomasterfrom
feature-expand-interval-improved-implementation

Conversation

@antvaset
Copy link
Copy Markdown
Contributor

@antvaset antvaset commented May 18, 2025

This PR improves the implementation of expand following the CQL spec.

What's new:

  • when the boundaries of the input intervals are more precise than the per quantity, the intervals are truncated to the precision of per
  • precision is taken into account when working out the boundaries of the output intervals
  • better handling of other edge cases

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 18, 2025

Formatting check succeeded!

@antvaset antvaset marked this pull request as draft May 18, 2025 23:34
…ation

# Conflicts:
#	Src/java/engine/src/main/java/org/opencds/cqf/cql/engine/elm/executing/ExpandEvaluator.java
@antvaset antvaset changed the base branch from feature-expand-interval to master June 3, 2025 15:10
antvaset added 6 commits June 4, 2025 07:43
…ation

# Conflicts:
#	Src/java/engine-fhir/src/test/java/org/hl7/fhirpath/CQLOperationsR4Test.java
#	Src/java/engine-fhir/src/test/java/org/hl7/fhirpath/TestFhirPath.java
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 7, 2025

Codecov Report

Attention: Patch coverage is 86.82927% with 27 lines in your changes missing coverage. Please review.

Project coverage is 64.83%. Comparing base (ec96342) to head (7c57386).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../cqf/cql/engine/elm/executing/ExpandEvaluator.java 76.92% 5 Missing and 7 partials ⚠️
...opencds/cqf/cql/engine/runtime/IntervalHelper.java 84.72% 5 Missing and 6 partials ⚠️
...cql/engine/elm/executing/PredecessorEvaluator.java 85.71% 1 Missing and 1 partial ⚠️
...f/cql/engine/elm/executing/SuccessorEvaluator.java 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1556      +/-   ##
============================================
+ Coverage     64.66%   64.83%   +0.16%     
  Complexity     1973     1973              
============================================
  Files           496      497       +1     
  Lines         28369    28486     +117     
  Branches       5616     5629      +13     
============================================
+ Hits          18346    18468     +122     
+ Misses         7748     7731      -17     
- Partials       2275     2287      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@antvaset antvaset marked this pull request as ready for review June 7, 2025 12:45
@antvaset antvaset requested review from JPercival and brynrhodes June 7, 2025 12:45
@sonarqubecloud
Copy link
Copy Markdown

@JPercival JPercival merged commit 68923ec into master Jun 10, 2025
7 checks passed
@JPercival JPercival deleted the feature-expand-interval-improved-implementation branch June 10, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants