[kubevirt-operator] Fix typo in VMNotRunningFor10Minutes alert #1770

lexfrei · 2025-12-29T13:07:04Z

What this PR does

Fix case sensitivity in status check for VMNotRunningFor10Minutes alert rule.

The metric kubevirt_vm_info uses status="Running" (capital R), but the alert rule was checking for status!="running" (lowercase), causing false alerts for running VMs.

Fixes #1552

Release note

[kubevirt-operator] Fix VMNotRunningFor10Minutes alert false positives

Summary by CodeRabbit

Bug Fixes
- Fixed alert rule condition for virtual machine status detection to ensure proper matching of running VMs.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Fix case sensitivity in status check: "running" → "Running". The metric uses "Running" (capital R), so the lowercase check was always triggering alerts even for running VMs. Fixes: #1552 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Aleksei Sviridkin <f@lex.la>

coderabbitai · 2025-12-29T13:07:16Z

📝 Walkthrough

Walkthrough

Corrects a case-sensitivity typo in a Prometheus alert rule for KubeVirt, changing the status filter from lowercase "running" to uppercase "Running" to match the actual metric values, fixing incorrect alert triggering for running VMs.

Changes

Cohort / File(s)	Summary
KubeVirt Alert Rule Fix `packages/system/kubevirt-operator/alerts/PrometheusRule.yaml`	Case-sensitivity correction in `kubevirt_vm_info` filter: `"running"` → `"Running"` in the `VMNotRunningFor10Minutes` alert expression to match actual metric values

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A typo lurked in the running state,
Where lowercase blocked the alert's fate,
With capital R, the metrics now align—
VMs running smoothly, alert working fine! 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main change: fixing a case-sensitivity typo in the VMNotRunningFor10Minutes alert rule by changing 'running' to 'Running'.
Linked Issues check	✅ Passed	The code change directly addresses issue #1552 by correcting the status comparison from 'running' to 'Running' to match the kubevirt_vm_info metric and prevent false positives for running VMs.
Out of Scope Changes check	✅ Passed	The PR contains only a focused change to the alert rule's status comparison, with no out-of-scope modifications to unrelated code or configurations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix-kubevirt-alert-typo

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 14803a4 and 7fab919.

📒 Files selected for processing (1)

packages/system/kubevirt-operator/alerts/PrometheusRule.yaml

🧰 Additional context used

📓 Path-based instructions (2)

packages/system/**

📄 CodeRabbit inference engine (AGENTS.md)

Use Helm Chart umbrella pattern with vendored upstream charts in charts/ directory

Files:

packages/system/kubevirt-operator/alerts/PrometheusRule.yaml

**/*.yaml

📄 CodeRabbit inference engine (AGENTS.md)

Do NOT directly edit upstream Helm charts in vendored charts directory; use proper chart vendoring mechanisms

Files:

packages/system/kubevirt-operator/alerts/PrometheusRule.yaml

🔇 Additional comments (1)

packages/system/kubevirt-operator/alerts/PrometheusRule.yaml (1)

13-13: Fix correctly aligns with the metric label casing and existing patterns.

The change to status!="Running" with a capital R is consistent with line 30 (phase!="Running"), and other metrics throughout the codebase use the same capitalization pattern (e.g., kube_pod_status_phase{phase="Running"}). The file follows the Helm Chart structure as required by the coding guidelines.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist · 2025-12-29T13:07:17Z

Summary of Changes

Hello @lexfrei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue causing false positive alerts for running virtual machines by correcting a case sensitivity mismatch in the VMNotRunningFor10Minutes Prometheus alert rule. By aligning the alert's status check with the actual metric's reported status, it ensures that alerts are only triggered for genuinely non-running VMs, improving the reliability of monitoring.

Highlights

Alert Rule Correction: The VMNotRunningFor10Minutes alert rule was updated to correctly handle case sensitivity in the VM status check. Previously, it checked for status!="running" (lowercase), but the kubevirt_vm_info metric reports status="Running" (capitalized), leading to false positive alerts for running VMs. The fix changes the comparison to status!="Running".

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly fixes a case-sensitivity typo in the VMNotRunningFor10Minutes alert, which was causing false positives. The change from running to Running is accurate. I've also included a suggestion to improve the logic of the alert expression itself. Using min_over_time instead of max_over_time will make the alert more reliable by ensuring it only fires when a VM has been in a non-running state for the full 10-minute duration, which aligns better with the alert's name and intent. This would help reduce alert fatigue from transient states.

packages/system/kubevirt-operator/alerts/PrometheusRule.yaml

github-actions · 2025-12-30T10:58:25Z

Successfully created backport PR for release-0.39:

[Backport release-0.39] [kubevirt-operator] Fix typo in VMNotRunningFor10Minutes alert #1775

…or10Minutes alert (#1775) # Description Backport of #1770 to `release-0.39`.

Revert PR #1770 which incorrectly changed status check from lowercase to uppercase. The actual metrics use lowercase: - kubevirt_vm_info uses status="running" (not "Running") - kubevirt_vmi_info uses phase="running" (not "Running") Verified by querying virt-controller metrics in instories cluster. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Aleksei Sviridkin <f@lex.la>

## What this PR does Reverts PR #1770 which incorrectly changed status/phase checks from lowercase to uppercase. The actual KubeVirt metrics use **lowercase**: - `kubevirt_vm_info` uses `status="running"` (not `"Running"`) - `kubevirt_vmi_info` uses `phase="running"` (not `"Running"`) ### Verification Queried virt-controller metrics directly in the instories cluster: ``` kubevirt_vm_info{...,status="running",status_group="running",...} 1 kubevirt_vmi_info{...,phase="running",...} 1 ``` Note: `kubectl get vm` shows `STATUS: Running` with capital R, but this is display formatting — the actual metric labels use lowercase. ### Release note ```release-note [kubevirt-operator] Fix VM alert rules to use correct lowercase status values ```

Revert PR #1770 which incorrectly changed status check from lowercase to uppercase. The actual metrics use lowercase: - kubevirt_vm_info uses status="running" (not "Running") - kubevirt_vmi_info uses phase="running" (not "Running") Verified by querying virt-controller metrics in instories cluster. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Aleksei Sviridkin <f@lex.la> (cherry picked from commit 36836fd)

## What this PR does Fix case sensitivity in status check for VMNotRunningFor10Minutes alert rule. The metric `kubevirt_vm_info` uses `status="Running"` (capital R), but the alert rule was checking for `status!="running"` (lowercase), causing false alerts for running VMs. Fixes #1552 ### Release note ```release-note [kubevirt-operator] Fix VMNotRunningFor10Minutes alert false positives ```  ## Summary by CodeRabbit * **Bug Fixes** * Fixed alert rule condition for virtual machine status detection to ensure proper matching of running VMs. ✏️ Tip: You can customize this high-level summary in your review settings.

## What this PR does Reverts PR #1770 which incorrectly changed status/phase checks from lowercase to uppercase. The actual KubeVirt metrics use **lowercase**: - `kubevirt_vm_info` uses `status="running"` (not `"Running"`) - `kubevirt_vmi_info` uses `phase="running"` (not `"Running"`) ### Verification Queried virt-controller metrics directly in the instories cluster: ``` kubevirt_vm_info{...,status="running",status_group="running",...} 1 kubevirt_vmi_info{...,phase="running",...} 1 ``` Note: `kubectl get vm` shows `STATUS: Running` with capital R, but this is display formatting — the actual metric labels use lowercase. ### Release note ```release-note [kubevirt-operator] Fix VM alert rules to use correct lowercase status values ```

## What this PR does Fix case sensitivity in status check for VMNotRunningFor10Minutes alert rule. The metric `kubevirt_vm_info` uses `status="Running"` (capital R), but the alert rule was checking for `status!="running"` (lowercase), causing false alerts for running VMs. Fixes #1552 ### Release note ```release-note [kubevirt-operator] Fix VMNotRunningFor10Minutes alert false positives ```  ## Summary by CodeRabbit * **Bug Fixes** * Fixed alert rule condition for virtual machine status detection to ensure proper matching of running VMs. ✏️ Tip: You can customize this high-level summary in your review settings.

## What this PR does Reverts PR #1770 which incorrectly changed status/phase checks from lowercase to uppercase. The actual KubeVirt metrics use **lowercase**: - `kubevirt_vm_info` uses `status="running"` (not `"Running"`) - `kubevirt_vmi_info` uses `phase="running"` (not `"Running"`) ### Verification Queried virt-controller metrics directly in the instories cluster: ``` kubevirt_vm_info{...,status="running",status_group="running",...} 1 kubevirt_vmi_info{...,phase="running",...} 1 ``` Note: `kubectl get vm` shows `STATUS: Running` with capital R, but this is display formatting — the actual metric labels use lowercase. ### Release note ```release-note [kubevirt-operator] Fix VM alert rules to use correct lowercase status values ```

Revert PR #1770 which incorrectly changed status check from lowercase to uppercase. The actual metrics use lowercase: - kubevirt_vm_info uses status="running" (not "Running") - kubevirt_vmi_info uses phase="running" (not "Running") Verified by querying virt-controller metrics in instories cluster. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Aleksei Sviridkin <f@lex.la> (cherry picked from commit 36836fd)

## What this PR does Fix case sensitivity in status check for VMNotRunningFor10Minutes alert rule. The metric `kubevirt_vm_info` uses `status="Running"` (capital R), but the alert rule was checking for `status!="running"` (lowercase), causing false alerts for running VMs. Fixes #1552 ### Release note ```release-note [kubevirt-operator] Fix VMNotRunningFor10Minutes alert false positives ```  ## Summary by CodeRabbit * **Bug Fixes** * Fixed alert rule condition for virtual machine status detection to ensure proper matching of running VMs. ✏️ Tip: You can customize this high-level summary in your review settings.

## What this PR does Reverts PR #1770 which incorrectly changed status/phase checks from lowercase to uppercase. The actual KubeVirt metrics use **lowercase**: - `kubevirt_vm_info` uses `status="running"` (not `"Running"`) - `kubevirt_vmi_info` uses `phase="running"` (not `"Running"`) ### Verification Queried virt-controller metrics directly in the instories cluster: ``` kubevirt_vm_info{...,status="running",status_group="running",...} 1 kubevirt_vmi_info{...,phase="running",...} 1 ``` Note: `kubectl get vm` shows `STATUS: Running` with capital R, but this is display formatting — the actual metric labels use lowercase. ### Release note ```release-note [kubevirt-operator] Fix VM alert rules to use correct lowercase status values ```

lexfrei requested review from kvaps, lllamnyp and nbykov0 as code owners December 29, 2025 13:07

lexfrei self-assigned this Dec 29, 2025

dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Dec 29, 2025

gemini-code-assist bot reviewed Dec 29, 2025

View reviewed changes

packages/system/kubevirt-operator/alerts/PrometheusRule.yaml Show resolved Hide resolved

kvaps approved these changes Dec 30, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 30, 2025

kvaps added backport Should change be backported on previus release and removed lgtm This PR has been approved by a maintainer labels Dec 30, 2025

kvaps merged commit f4e4346 into main Dec 30, 2025
28 checks passed

kvaps deleted the fix-kubevirt-alert-typo branch December 30, 2025 10:58

github-actions bot mentioned this pull request Dec 30, 2025

[Backport release-0.39] [kubevirt-operator] Fix typo in VMNotRunningFor10Minutes alert #1775

Merged

kvaps added a commit that referenced this pull request Dec 30, 2025

[Backport release-0.39] [kubevirt-operator] Fix typo in VMNotRunningF…

9300309

…or10Minutes alert (#1775) # Description Backport of #1770 to `release-0.39`.

lexfrei mentioned this pull request Jan 5, 2026

[kubevirt-operator] Revert incorrect case change in VM alerts #1804

Merged

coderabbitai bot mentioned this pull request Jan 10, 2026

[docs] Generate missing changelogs for v0.37.10, v0.38.5-v0.38.8, v0.39.2-v0.39.4, and v0.40.0 #1848

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[kubevirt-operator] Fix typo in VMNotRunningFor10Minutes alert #1770

[kubevirt-operator] Fix typo in VMNotRunningFor10Minutes alert #1770

Uh oh!

lexfrei commented Dec 29, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 29, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

gemini-code-assist bot commented Dec 29, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[kubevirt-operator] Fix typo in VMNotRunningFor10Minutes alert #1770

[kubevirt-operator] Fix typo in VMNotRunningFor10Minutes alert #1770

Uh oh!

Conversation

lexfrei commented Dec 29, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does

Release note

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

gemini-code-assist bot commented Dec 29, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lexfrei commented Dec 29, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 29, 2025 •

edited

Loading