Skip to content

added command line option --parameters <user_parameters.json> for Issue #187#199

Closed
ryanolson wants to merge 2 commits intocookiecutter:masterfrom
ryanolson:issue_187
Closed

added command line option --parameters <user_parameters.json> for Issue #187#199
ryanolson wants to merge 2 commits intocookiecutter:masterfrom
ryanolson:issue_187

Conversation

@ryanolson
Copy link
Copy Markdown

@ryanolson ryanolson commented Jul 9, 2014

This pull request closes Issue #187

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 9, 2014

Coverage Status

Coverage increased (+1.03%) when pulling 0513f61 on ryanolson:issue_187 into 08afd82 on audreyr:master.

@ryanolson
Copy link
Copy Markdown
Author

ryanolson commented Jul 9, 2014

@audreyr - Could you please review this small modification and merge it?

@pydanny pydanny added this to the 0.8.0 - Extra Context milestone Jul 9, 2014
@pydanny
Copy link
Copy Markdown
Member

pydanny commented Jul 9, 2014

Hey @ryanolson, thanks for increasing code coverage! As your PR kind-of an extra context issue, I've triaged this PR to 0.8.0. It might get merged in before our planned 0.8.0 release this weekend-ish.

Note: Even 'small' modifications to Cookiecutter go through our rigorous merge process: https://gist.github.com/audreyr/4feef90445b9680475f2.

ryanolson referenced this pull request in emonty/cookiecutter Jul 9, 2014
@emonty
Add ability to pass in a context file
3024791 
If cookiecutter is used inside of a project creation automation, you
want to not only give --no-input, but also supply input values other
than the ones in the default file.

Add a command line option, --context-file, which allows overriding the
default location for default values.
@ryanolson ryanolson mentioned this pull request Jul 9, 2014
Closed
michaeljoseph
michaeljoseph reviewed Jul 12, 2014
View reviewed changes
cookiecutter/generate.py Outdated
Copy link
Copy Markdown
Contributor

@michaeljoseph michaeljoseph Jul 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use utils.unicode_open here.

@michaeljoseph
Copy link
Copy Markdown
Contributor

michaeljoseph commented Jul 12, 2014

🔔 @ryanolson

@michaeljoseph michaeljoseph mentioned this pull request Jul 12, 2014
Closed
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 13, 2014

Coverage Status

Coverage increased (+1.02%) when pulling 5f991d8 on ryanolson:issue_187 into 08afd82 on audreyr:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 13, 2014

Coverage Status

Coverage increased (+1.02%) when pulling 5f991d8 on ryanolson:issue_187 into 08afd82 on audreyr:master.

@ryanolson
Copy link
Copy Markdown
Author

ryanolson commented Jul 13, 2014

I've updated the branch with your requested changes. I modified the API behavior to be similar to #161 in which a dictionary object is passed to cookeicutter rather than a filename. The --parameters JSON file is read in main and the dictionary rather than the filename is passed to cookiecutter.

@ryanolson ryanolson mentioned this pull request Jul 15, 2014
Closed
@michaeljoseph michaeljoseph mentioned this pull request Aug 7, 2014
Closed
@michaeljoseph
Copy link
Copy Markdown
Contributor

michaeljoseph commented Aug 7, 2014

👀 #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement This issue/PR relates to a feature request.

Projects

None yet

Milestone

0.8.0 - Extra Context

Development

Successfully merging this pull request may close these issues.

4 participants

@ryanolson @coveralls @pydanny @michaeljoseph