Skip to content

Remove EOL Python Versions 3.3 and 3.4#1181

Merged
pydanny merged 1 commit intocookiecutter:masterfrom
insspb:drop34
Jul 12, 2019
Merged

Remove EOL Python Versions 3.3 and 3.4#1181
pydanny merged 1 commit intocookiecutter:masterfrom
insspb:drop34

Conversation

@insspb
Copy link
Copy Markdown
Member

@insspb insspb commented Jul 2, 2019

Changes to original #1178 PR are:

  • Removed python 3.3 mentions in docs/contributor_guidelines.rst
  • Added python 3.4 restriction to setup.py

@insspb insspb mentioned this pull request Jul 2, 2019
Closed
6 tasks
@insspb
Copy link
Copy Markdown
Member Author

insspb commented Jul 2, 2019

Tested locally with tox:

___________________________________________________________________________________________________________ summary ___________________________________________________________________________________________________________
  py27: commands succeeded
  py35: commands succeeded
  py36: commands succeeded
  py37: commands succeeded
ERROR:   pypy: InterpreterNotFound: pypy
  flake8: commands succeeded

@insspb insspb added the needs-review PR Only: This PR require review from other developer label Jul 2, 2019
@ssbarnea
Copy link
Copy Markdown
Member

ssbarnea commented Jul 2, 2019

Just remove "Merged #1178" suffix from the PR title and it should be fine.

@ssbarnea ssbarnea added needs-merge and removed needs-review PR Only: This PR require review from other developer labels Jul 2, 2019
This was referenced Jul 2, 2019
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
cclauss
cclauss reviewed Jul 2, 2019
View reviewed changes
.travis.yml
# Config file for automatic testing at travis-ci.org

dist: xenial
sudo: false
Copy link
Copy Markdown

@cclauss cclauss Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sudo: tag is now fully deprecated in Travis CI so all lines that start with sudo: can safely be deleted.

Copy link
Copy Markdown
Member

@ssbarnea ssbarnea Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss is right but at the same time I hope to see it merged before travis deprecates another feature. Travis config was broken for ages...

@insspb insspb mentioned this pull request Jul 3, 2019
Merged
@insspb insspb changed the title Merged #1178 Remove EOL Python Versions , with changes Remove EOL Python Versions 3.3 and 3.4 Jul 3, 2019
@ssbarnea ssbarnea closed this Jul 11, 2019
@ssbarnea ssbarnea reopened this Jul 11, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 11, 2019 •
edited
Loading

Codecov Report

Merging #1181 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1181      +/-   ##
==========================================
- Coverage     100%   99.74%   -0.26%     
==========================================
  Files          18       18              
  Lines         783      783              
==========================================
- Hits          783      781       -2     
- Misses          0        2       +2
Impacted Files Coverage Δ
cookiecutter/utils.py 96% <0%> (-4%) ⬇️
cookiecutter/repository.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9007ae5...d1cefe2. Read the comment docs.

cclauss
cclauss approved these changes Jul 11, 2019
View reviewed changes
.travis.yml
env: TOXENV=py37
- python: pypy
env: TOXENV=pypy
- python: 3.5
Copy link
Copy Markdown

@cclauss cclauss Jul 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 should be run on Python 3.7 instead of 3.5 to catch the new syntax errors associated with async and await and new deprecation warnings for Python 3.8

Copy link
Copy Markdown
Member

@ssbarnea ssbarnea Jul 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right but I would merge this in current form and pospone any other fine tunning for later. The totally broken CI is far more damaging that these small details.

I am saying this because the change because there is no ending regarding number of fixes/improvements.

Another note: I would personally disable CodeCov as I find it more of a source of noise than somethign useful.

@cclauss
Copy link
Copy Markdown

cclauss commented Jul 11, 2019 •
edited
Loading

On the pytest warning \( --> \\(

4 C901 'generate_files' is too complex (16)
2 E121 continuation line under-indented for hanging indent
6 E122 continuation line missing indentation or outdented
59 E265 block comment should start with '# '
1 E302 expected 2 blank lines, found 1
1 E305 expected 2 blank lines after class or function definition, found 1
1 E401 multiple imports on one line
1 E402 module level import not at top of file
1 F811 redefinition of unused 'sys' from line 14
2 W605 invalid escape sequence '('
78

@ssbarnea
Copy link
Copy Markdown
Member

ssbarnea commented Jul 12, 2019

@cclauss I would be more than happy to make another PR to fix the warnings noted by you. At the same time lets remember that these warnings are not caused by that PR code itself.

I cannot update this PR myself, that is why I am trying to see it merged sooner we already wasted weeks trying to get someone to merge fixes for a broken CI.

@cclauss
Copy link
Copy Markdown

cclauss commented Jul 12, 2019

Weeks?!? #1085 was open for a year before it was closed in favor of this effort.

hackebrot
hackebrot approved these changes Jul 12, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@hackebrot hackebrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@hackebrot
Copy link
Copy Markdown
Member

hackebrot commented Jul 12, 2019

Hi @insspb! 👋

Can you please update your commit to also give credit to @jamescurtin for their work on #1178?

@pydanny
Copy link
Copy Markdown
Member

pydanny commented Jul 12, 2019

Thanks to you and @jamescurtin (#1178) for all the work done on this PR!

@pydanny pydanny merged commit ee3e5b2 into cookiecutter:master Jul 12, 2019
@luzfcb luzfcb mentioned this pull request Aug 10, 2019
Merged
5 tasks
@kiancm kiancm mentioned this pull request Oct 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@hackebrot hackebrot hackebrot approved these changes

+1 more reviewer

@cclauss cclauss cclauss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pydanny pydanny

@audreyfeldroy audreyfeldroy

@ssbarnea ssbarnea

@hackebrot hackebrot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@insspb @ssbarnea @codecov-io @cclauss @hackebrot @pydanny @audreyfeldroy