Skip to content

Remove EOL Python Versions#1178

Closed
jamescurtin wants to merge 1 commit intocookiecutter:masterfrom
jamescurtin:remove-eol-pyversions
Closed

Remove EOL Python Versions#1178
jamescurtin wants to merge 1 commit intocookiecutter:masterfrom
jamescurtin:remove-eol-pyversions

Conversation

@jamescurtin
Copy link
Copy Markdown

According to the Python release schedule, Python 3.4 is past end of life, and Python 3.7 has entered into bugfix status. This PR updates the package to reflect this.

@jamescurtin jamescurtin force-pushed the remove-eol-pyversions branch from f389545 to f7015df Compare June 11, 2019 01:53
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1178 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1178   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          18      18           
  Lines         783     783           
======================================
  Hits          783     783

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc7b98...f7015df. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1178 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1178   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          18      18           
  Lines         783     783           
======================================
  Hits          783     783

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc7b98...f7015df. Read the comment docs.

@insspb
Copy link
Copy Markdown
Member

insspb commented Jun 13, 2019

Everything looks correct. I leave this comment just to see when it will be answered by the core team or merged. Unfortunately, core development looks dead.

Copy link
Copy Markdown
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge this ASAP as this is needed for testing other incoming fixes.

@jamescurtin
Copy link
Copy Markdown
Author

HI, @ssbarnea, I do not have write access to this repo. Please merge if you can. Thanks!

@ssbarnea
Copy link
Copy Markdown
Member

@pydanny safe to merge.

Copy link
Copy Markdown
Member

@insspb insspb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup.py line 61 should be changed from:

python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*',

to:

python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*', , !=3.4.*',

your new functionality into a function with a docstring, and add the
feature to the list in README.rst.
3. The pull request should work for Python 2.7, 3.3, 3.4, 3.5, 3.6, and PyPy on
3. The pull request should work for Python 2.7, 3.3, 3.5, 3.6, 3.7, and PyPy on
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python 3.3 should be removed too

@insspb
Copy link
Copy Markdown
Member

insspb commented Jul 1, 2019

https://img.shields.io/pypi/pyversions/cookiecutter.svg change should be checked too after this merged.

@ssbarnea ssbarnea added developers This issue/PR has request to other project developers needs-merge labels Jul 2, 2019
@insspb
Copy link
Copy Markdown
Member

insspb commented Jul 2, 2019

Closed as a duplicate to speed up the review process. Everything from here merged to #1181

@insspb insspb closed this Jul 2, 2019
pydanny pushed a commit that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developers This issue/PR has request to other project developers duplicate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants