Travis CI: Add Python 3.7 to the testing#1085
Travis CI: Add Python 3.7 to the testing#1085cclauss wants to merge 9 commits intocookiecutter:masterfrom
Conversation
Python 3.7 must run with sudo on xenial as described at travis-ci/travis-ci#9069
Also, emoved the hardcoding of flake8 versions because if the linter improves then we want those improvements.
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
======================================
Coverage 100% 100%
======================================
Files 18 18
Lines 783 783
======================================
Hits 783 783Continue to review full report at Codecov.
|
|
@hugovk Your review please... Did I miss anything? |
|
A few extra places:
|
|
Hi @cclauss! Thank you for this PR 🍪 Happy to merge this - @michaeljoseph thoughts? |
|
@hackebrot @michaeljoseph Shall we merge this? |
browniebroke
left a comment
There was a problem hiding this comment.
Anything missing to be able to merge this?
|
Travis are now recommending removing the sudo tag. "If you currently specify sudo: false in your .travis.yml, we recommend removing that configuration" |
| [testenv:flake8] | ||
| deps = | ||
| flake8==3.5.0 | ||
| flake8 |
There was a problem hiding this comment.
The Flake8 test failed... Looks like the newer version of flake8 is finding some problems now?
flake8 runtests: commands[0] | flake8 cookiecutter tests setup.py
tests/test_generate_context.py:90:32: W605 invalid escape sequence '\('
tests/test_generate_context.py:90:41: W605 invalid escape sequence '\)'
Not sure I understand the issue though... Should we change this line to r'...' string?
Fix W605 flake8 warning in test
Travis CI must run Python 3.7 with sudo on xenial as described at travis-ci/travis-ci#9069
Tox: Removed the hardcoding of flake8 version because if the linter improves then we want our testing to benefit from those improvements.