Skip to content

Add Code of Conduct#374

Merged
debarshiray merged 1 commit intocontainers:masterfrom
TomSweeneyRedHat:coc
Feb 12, 2020
Merged

Add Code of Conduct#374
debarshiray merged 1 commit intocontainers:masterfrom
TomSweeneyRedHat:coc

Conversation

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com

As the title says.

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed.

@martymichal
Copy link
Copy Markdown
Member

The tests are throwing a false positive. Can be merged.

martymichal added a commit to martymichal/toolbox that referenced this pull request Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to
mistakes in their design. The tests very quite chaotically structured.
Because of that images were deleted and pulled too often which caused
several false positives (containers#374, containers#372).

This changes the strucutre of the tests in a major way. The tests (resp.
commands) are now ran in a manner to kinda simulate the way Toolbox is
used. From clean state, through creating containers, using them and in
the end deleting them. This should reduce the strain on the bandwidth
and possibly even speed up the tests themselves.

More information in the README.md in the directory with the tests.
martymichal added a commit to martymichal/toolbox that referenced this pull request Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to
mistakes in their design. The tests very quite chaotically structured.
Because of that images were deleted and pulled too often which caused
several false positives (containers#374, containers#372).

This changes the strucutre of the tests in a major way. The tests (resp.
commands) are now ran in a manner to kinda simulate the way Toolbox is
used. From clean state, through creating containers, using them and in
the end deleting them. This should reduce the strain on the bandwidth
and possibly even speed up the tests themselves.

More information in the README.md in the directory with the tests.
martymichal added a commit to martymichal/toolbox that referenced this pull request Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to
mistakes in their design. The tests very quite chaotically structured.
Because of that images were deleted and pulled too often which caused
several false positives (containers#374, containers#372).

This changes the strucutre of the tests in a major way. The tests (resp.
commands) are now ran in a manner to kinda simulate the way Toolbox is
used. From clean state, through creating containers, using them and in
the end deleting them. This should reduce the strain on the bandwidth
and possibly even speed up the tests themselves.

More information in the README.md in the directory with the tests.
martymichal added a commit to martymichal/toolbox that referenced this pull request Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to
mistakes in their design. The tests very quite chaotically structured.
Because of that images were deleted and pulled too often which caused
several false positives (containers#374, containers#372).

This changes the strucutre of the tests in a major way. The tests (resp.
commands) are now ran in a manner to kinda simulate the way Toolbox is
used. From clean state, through creating containers, using them and in
the end deleting them. This should reduce the strain on the bandwidth
and possibly even speed up the tests themselves.

More information in the README.md in the directory with the tests.
martymichal added a commit to martymichal/toolbox that referenced this pull request Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to
mistakes in their design. The tests very quite chaotically structured.
Because of that images were deleted and pulled too often which caused
several false positives (containers#374, containers#372).

This changes the strucutre of the tests in a major way. The tests (resp.
commands) are now ran in a manner to kinda simulate the way Toolbox is
used. From clean state, through creating containers, using them and in
the end deleting them. This should reduce the strain on the bandwidth
and possibly even speed up the tests themselves.

More information in the README.md in the directory with the tests.
martymichal added a commit to martymichal/toolbox that referenced this pull request Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to
mistakes in their design. The tests very quite chaotically structured.
Because of that images were deleted and pulled too often which caused
several false positives (containers#374, containers#372).

This changes the strucutre of the tests in a major way. The tests (resp.
commands) are now ran in a manner to kinda simulate the way Toolbox is
used. From clean state, through creating containers, using them and in
the end deleting them. This should reduce the strain on the bandwidth
and possibly even speed up the tests themselves.

More information in the README.md in the directory with the tests.
martymichal added a commit to martymichal/toolbox that referenced this pull request Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to
mistakes in their design. The tests very quite chaotically structured.
Because of that images were deleted and pulled too often which caused
several false positives (containers#374, containers#372).

This changes the strucutre of the tests in a major way. The tests (resp.
commands) are now ran in a manner to kinda simulate the way Toolbox is
used. From clean state, through creating containers, using them and in
the end deleting them. This should reduce the strain on the bandwidth
and possibly even speed up the tests themselves.

More information in the README.md in the directory with the tests.
martymichal added a commit to martymichal/toolbox that referenced this pull request Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to
mistakes in their design. The tests very quite chaotically structured.
Because of that images were deleted and pulled too often which caused
several false positives (containers#374, containers#372).

This changes the strucutre of the tests in a major way. The tests (resp.
commands) are now ran in a manner to kinda simulate the way Toolbox is
used. From clean state, through creating containers, using them and in
the end deleting them. This should reduce the strain on the bandwidth
and possibly even speed up the tests themselves.

More information in the README.md in the directory with the tests.
martymichal added a commit to martymichal/toolbox that referenced this pull request Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to
mistakes in their design. The tests very quite chaotically structured.
Because of that images were deleted and pulled too often which caused
several false positives (containers#374, containers#372).

This changes the strucutre of the tests in a major way. The tests (resp.
commands) are now ran in a manner to kinda simulate the way Toolbox is
used. From clean state, through creating containers, using them and in
the end deleting them. This should reduce the strain on the bandwidth
and possibly even speed up the tests themselves.

More information in the README.md in the directory with the tests.
martymichal added a commit to martymichal/toolbox that referenced this pull request Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to
mistakes in their design. The tests very quite chaotically structured.
Because of that images were deleted and pulled too often which caused
several false positives (containers#374, containers#372).

This changes the strucutre of the tests in a major way. The tests (resp.
commands) are now ran in a manner to kinda simulate the way Toolbox is
used. From clean state, through creating containers, using them and in
the end deleting them. This should reduce the strain on the bandwidth
and possibly even speed up the tests themselves.

More information in the README.md in the directory with the tests.
martymichal added a commit to martymichal/toolbox that referenced this pull request Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to
mistakes in their design. The tests very quite chaotically structured.
Because of that images were deleted and pulled too often which caused
several false positives (containers#374, containers#372).

This changes the strucutre of the tests in a major way. The tests (resp.
commands) are now ran in a manner to kinda simulate the way Toolbox is
used. From clean state, through creating containers, using them and in
the end deleting them. This should reduce the strain on the bandwidth
and possibly even speed up the tests themselves.

More information in the README.md in the directory with the tests.
@TomSweeneyRedHat
Copy link
Copy Markdown
Member Author

@rhatdan PTAL

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Feb 11, 2020

@debarshiray PTAL

containers#374

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
@debarshiray debarshiray merged commit 518b8f5 into containers:master Feb 12, 2020
@debarshiray
Copy link
Copy Markdown
Member

Thanks, @TomSweeneyRedHat !

@TomSweeneyRedHat TomSweeneyRedHat deleted the coc branch February 12, 2020 18:01
debarshiray pushed a commit to martymichal/toolbox that referenced this pull request Feb 18, 2020
The tests introduced by commit b5cdc57 have proven to be
rather unstable due to mistakes in their design. The tests were quite
chaotically structured, and because of that images were deleted and
pulled too often, causing several false positives [1, 2].

This changes the structure of the tests in a major way. The tests
(resp. commands) are now run in a manner that better simulates the way
Toolbox is actually used. From a clean state, through creating
containers, using them and in the end deleting them. This should
reduce the strain on the bandwidth and possibly even speed up the
tests themselves.

[1] containers#372
[2] containers#374

containers#375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants