Load fedora-toolbox image in the pre-phase to prevent ci failure#372
Closed
TristanCacqueray wants to merge 1 commit intocontainers:masterfrom
Closed
Load fedora-toolbox image in the pre-phase to prevent ci failure#372TristanCacqueray wants to merge 1 commit intocontainers:masterfrom
TristanCacqueray wants to merge 1 commit intocontainers:masterfrom
Conversation
Contributor
Author
|
See the failures in the last periodic run: https://softwarefactory-project.io/zuul/t/local/buildset/b532a118c7044bcaa522f085052f6261 |
This change adds a pre task to load the fedora-toolbox image from the registry to prevent false positive failure when: Trying to pull registry.fedoraproject.org/f31/fedora-toolbox:31... invalid status code from registry 503 (Service Unavailable)
d726433 to
3267074
Compare
|
Build failed.
|
Contributor
Author
|
That doesn't seems enough since the test seems to rm the image... |
Member
That is true. I'm not very happy with the state the tests are in. I need to adjust them a bit. We'll use this certainly. |
martymichal
added a commit
to martymichal/toolbox
that referenced
this pull request
Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to mistakes in their design. The tests very quite chaotically structured. Because of that images were deleted and pulled too often which caused several false positives (containers#374, containers#372). This changes the strucutre of the tests in a major way. The tests (resp. commands) are now ran in a manner to kinda simulate the way Toolbox is used. From clean state, through creating containers, using them and in the end deleting them. This should reduce the strain on the bandwidth and possibly even speed up the tests themselves. More information in the README.md in the directory with the tests.
martymichal
added a commit
to martymichal/toolbox
that referenced
this pull request
Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to mistakes in their design. The tests very quite chaotically structured. Because of that images were deleted and pulled too often which caused several false positives (containers#374, containers#372). This changes the strucutre of the tests in a major way. The tests (resp. commands) are now ran in a manner to kinda simulate the way Toolbox is used. From clean state, through creating containers, using them and in the end deleting them. This should reduce the strain on the bandwidth and possibly even speed up the tests themselves. More information in the README.md in the directory with the tests.
martymichal
added a commit
to martymichal/toolbox
that referenced
this pull request
Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to mistakes in their design. The tests very quite chaotically structured. Because of that images were deleted and pulled too often which caused several false positives (containers#374, containers#372). This changes the strucutre of the tests in a major way. The tests (resp. commands) are now ran in a manner to kinda simulate the way Toolbox is used. From clean state, through creating containers, using them and in the end deleting them. This should reduce the strain on the bandwidth and possibly even speed up the tests themselves. More information in the README.md in the directory with the tests.
martymichal
added a commit
to martymichal/toolbox
that referenced
this pull request
Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to mistakes in their design. The tests very quite chaotically structured. Because of that images were deleted and pulled too often which caused several false positives (containers#374, containers#372). This changes the strucutre of the tests in a major way. The tests (resp. commands) are now ran in a manner to kinda simulate the way Toolbox is used. From clean state, through creating containers, using them and in the end deleting them. This should reduce the strain on the bandwidth and possibly even speed up the tests themselves. More information in the README.md in the directory with the tests.
martymichal
added a commit
to martymichal/toolbox
that referenced
this pull request
Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to mistakes in their design. The tests very quite chaotically structured. Because of that images were deleted and pulled too often which caused several false positives (containers#374, containers#372). This changes the strucutre of the tests in a major way. The tests (resp. commands) are now ran in a manner to kinda simulate the way Toolbox is used. From clean state, through creating containers, using them and in the end deleting them. This should reduce the strain on the bandwidth and possibly even speed up the tests themselves. More information in the README.md in the directory with the tests.
martymichal
added a commit
to martymichal/toolbox
that referenced
this pull request
Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to mistakes in their design. The tests very quite chaotically structured. Because of that images were deleted and pulled too often which caused several false positives (containers#374, containers#372). This changes the strucutre of the tests in a major way. The tests (resp. commands) are now ran in a manner to kinda simulate the way Toolbox is used. From clean state, through creating containers, using them and in the end deleting them. This should reduce the strain on the bandwidth and possibly even speed up the tests themselves. More information in the README.md in the directory with the tests.
martymichal
added a commit
to martymichal/toolbox
that referenced
this pull request
Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to mistakes in their design. The tests very quite chaotically structured. Because of that images were deleted and pulled too often which caused several false positives (containers#374, containers#372). This changes the strucutre of the tests in a major way. The tests (resp. commands) are now ran in a manner to kinda simulate the way Toolbox is used. From clean state, through creating containers, using them and in the end deleting them. This should reduce the strain on the bandwidth and possibly even speed up the tests themselves. More information in the README.md in the directory with the tests.
martymichal
added a commit
to martymichal/toolbox
that referenced
this pull request
Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to mistakes in their design. The tests very quite chaotically structured. Because of that images were deleted and pulled too often which caused several false positives (containers#374, containers#372). This changes the strucutre of the tests in a major way. The tests (resp. commands) are now ran in a manner to kinda simulate the way Toolbox is used. From clean state, through creating containers, using them and in the end deleting them. This should reduce the strain on the bandwidth and possibly even speed up the tests themselves. More information in the README.md in the directory with the tests.
Merged
martymichal
added a commit
to martymichal/toolbox
that referenced
this pull request
Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to mistakes in their design. The tests very quite chaotically structured. Because of that images were deleted and pulled too often which caused several false positives (containers#374, containers#372). This changes the strucutre of the tests in a major way. The tests (resp. commands) are now ran in a manner to kinda simulate the way Toolbox is used. From clean state, through creating containers, using them and in the end deleting them. This should reduce the strain on the bandwidth and possibly even speed up the tests themselves. More information in the README.md in the directory with the tests.
Member
|
@TristanCacqueray I took the liberty of using your PR commit in #375 where I updated the tests to prevent false-positive results. If you don't mind, I'll close this PR. |
Contributor
Author
|
@HarryMichal thanks! |
martymichal
added a commit
to martymichal/toolbox
that referenced
this pull request
Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to mistakes in their design. The tests very quite chaotically structured. Because of that images were deleted and pulled too often which caused several false positives (containers#374, containers#372). This changes the strucutre of the tests in a major way. The tests (resp. commands) are now ran in a manner to kinda simulate the way Toolbox is used. From clean state, through creating containers, using them and in the end deleting them. This should reduce the strain on the bandwidth and possibly even speed up the tests themselves. More information in the README.md in the directory with the tests.
martymichal
added a commit
to martymichal/toolbox
that referenced
this pull request
Feb 10, 2020
The tests introduced by containers#250 have proven to be rather unstable due to mistakes in their design. The tests very quite chaotically structured. Because of that images were deleted and pulled too often which caused several false positives (containers#374, containers#372). This changes the strucutre of the tests in a major way. The tests (resp. commands) are now ran in a manner to kinda simulate the way Toolbox is used. From clean state, through creating containers, using them and in the end deleting them. This should reduce the strain on the bandwidth and possibly even speed up the tests themselves. More information in the README.md in the directory with the tests.
debarshiray
pushed a commit
to martymichal/toolbox
that referenced
this pull request
Feb 18, 2020
The tests introduced by commit b5cdc57 have proven to be rather unstable due to mistakes in their design. The tests were quite chaotically structured, and because of that images were deleted and pulled too often, causing several false positives [1, 2]. This changes the structure of the tests in a major way. The tests (resp. commands) are now run in a manner that better simulates the way Toolbox is actually used. From a clean state, through creating containers, using them and in the end deleting them. This should reduce the strain on the bandwidth and possibly even speed up the tests themselves. [1] containers#372 [2] containers#374 containers#375
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a pre task to load the fedora-toolbox image from
the registry to prevent false positive failure when:
Trying to pull registry.fedoraproject.org/f31/fedora-toolbox:31...
invalid status code from registry 503 (Service Unavailable)