Skip to content

chore(deps): update dependency containers/automation_images to v20230726#18612

Merged
openshift-merge-robot merged 7 commits intomainfrom
renovate/major-ci-vm-image
Aug 3, 2023
Merged

chore(deps): update dependency containers/automation_images to v20230726#18612
openshift-merge-robot merged 7 commits intomainfrom
renovate/major-ci-vm-image

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented May 17, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
containers/automation_images major 20230426t140447z-f38f37d12 -> 20230517t144652z-f38f37d12

Release Notes

containers/automation_images

v20230517t144652z-f38f37d12

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Pull requests that update a dependency file release-note-none labels May 17, 2023
@renovate renovate bot requested a review from cevich May 17, 2023 17:33
Copy link
Copy Markdown
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming tests pass) - See also #18439

@Luap99
Copy link
Copy Markdown
Member

Luap99 commented May 19, 2023

@Luap99
Copy link
Copy Markdown
Member

Luap99 commented May 19, 2023

@cevich
Copy link
Copy Markdown
Member

cevich commented May 19, 2023

Thanks Paul for checking & pinging. I managed to completely loose track of this PR 😞

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented May 19, 2023

Added to #18577 to see if this fixes both problems.

@cevich cevich force-pushed the renovate/major-ci-vm-image branch from 10045a0 to 2dd5ff9 Compare May 23, 2023 20:09
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label May 23, 2023
@cevich
Copy link
Copy Markdown
Member

cevich commented May 23, 2023

force-push: Attempted rebasing ontop of Dan's #18577 since it's CI went all green.

@cevich
Copy link
Copy Markdown
Member

cevich commented May 24, 2023

@rhatdan FWIW: rebased with your PR, seems we get a handful of checkpoint and SELinux test failures.

@Luap99
Copy link
Copy Markdown
Member

Luap99 commented May 24, 2023

I don't see how #18577 is relevant for the test failures?

@cevich
Copy link
Copy Markdown
Member

cevich commented May 24, 2023

I don't see how #18577 is relevant for the test failures?

Honestly I'm just throwing a bucket of golf-balls and hoping one lands in the hole. I read Dan's comment above and thought I'd give it a try. I should probably pull it out and rebase again, see if anything's changed from your assessment.

@cevich cevich force-pushed the renovate/major-ci-vm-image branch from 2dd5ff9 to 28f4a2b Compare May 24, 2023 14:27
@github-actions github-actions bot removed the kind/api-change Change to remote API; merits scrutiny label May 24, 2023
@cevich
Copy link
Copy Markdown
Member

cevich commented May 31, 2023

@giuseppe
Copy link
Copy Markdown
Member

giuseppe commented Jun 1, 2023

are we using crun 1.8.5? There was an issue in crun 1.8.4 with CRIU on Fedora that could have caused this problem

@Luap99
Copy link
Copy Markdown
Member

Luap99 commented Jun 1, 2023

CI logs says crun-1.8.4-1.fc38-x86_64 so no.

@cevich
Copy link
Copy Markdown
Member

cevich commented Jun 1, 2023

Thanks @giuseppe and @Luap99. Darn, so that means 1.8.5 wasn't in the updates-testing repo. at image-build time (a few weeks ago). I see the same test is failing on rawhide as well, with crun-1.8.4-1.fc39-x86_64. The bodhi pages show 1.8.5 entries from last week. So it sounds like I simply need to build newer CI VM Images then...

@cevich
Copy link
Copy Markdown
Member

cevich commented Jun 1, 2023

...opened containers/automation_images#281

@cevich cevich force-pushed the renovate/major-ci-vm-image branch from 28f4a2b to 24f9b0b Compare June 1, 2023 17:51
@cevich cevich changed the title chore(deps): update dependency containers/automation_images to v20230517 chore(deps): update dependency containers/automation_images to v20230601 Jun 1, 2023
@cevich
Copy link
Copy Markdown
Member

cevich commented Jun 1, 2023

Force-push: New CI VM images.

@cevich cevich force-pushed the renovate/major-ci-vm-image branch from 24f9b0b to 0900704 Compare June 5, 2023 16:45
@renovate
Copy link
Copy Markdown
Contributor Author

renovate bot commented Jun 5, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@cevich cevich force-pushed the renovate/major-ci-vm-image branch from 0900704 to cd9d243 Compare June 12, 2023 15:13
@cevich
Copy link
Copy Markdown
Member

cevich commented Jun 12, 2023

force-push: Rebased.

@cevich
Copy link
Copy Markdown
Member

cevich commented Jun 12, 2023

All system tests failing with:

Failed tests (3):
 - 410 podman selinux: container with label=disable
 - 411 podman selinux: privileged container
 - 416 podman selinux: pid=host

I did not look deeply, for now I'm assuming it's related to the fixes Dan's working on.

@cevich cevich force-pushed the renovate/major-ci-vm-image branch from 74a68a5 to 4c93d14 Compare August 1, 2023 15:35
@cevich
Copy link
Copy Markdown
Member

cevich commented Aug 1, 2023

Force-push: I've reached my limit on this PR, and lack of F38 + updated rawhide testing at-large is hampering ongoing development and pending/imminent releases. Added skips for all persistently failing tests, with "TODO/FIXME" comments and references where possible.

@edsantiago IIRC, you have a preferred format for these kinds of skip messages. Please advise how you'd like them to appear. This push is to see if we can even get a clean-run at this point (w/o new images).

Copy link
Copy Markdown
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just skip. Two requests inline, neither is a blocker.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2023
@edsantiago
Copy link
Copy Markdown
Member

You also need to skip this test in rawhide, same BZ:

@test "podman update - test all options" {

@cevich cevich force-pushed the renovate/major-ci-vm-image branch 2 times, most recently from 95124bc to 20e31bc Compare August 1, 2023 18:04
cevich and others added 4 commits August 1, 2023 15:26
Ref: #19407

Signed-off-by: Chris Evich <cevich@redhat.com>
Ref: #19471

Signed-off-by: Chris Evich <cevich@redhat.com>
Requires currently unavailable 0.0~git20230625.32660ce-1 or later.

Signed-off-by: Chris Evich <cevich@redhat.com>
Also update Fedora and Debian names.  Include ID of broken images in
`validate_task` comment about broken rawhide.  This should get picked
up by renovate next time images are updated - hopefully prompting
someone to re-enable the check.

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich force-pushed the renovate/major-ci-vm-image branch from 20e31bc to d74c225 Compare August 1, 2023 19:40
@cevich
Copy link
Copy Markdown
Member

cevich commented Aug 1, 2023

Force-push: 43rd time's the charm?

@cevich
Copy link
Copy Markdown
Member

cevich commented Aug 2, 2023

@containers/podman-maintainers PTAL. This isn't perfect, I've had to add some test skips and workarounds. But for months worth of trying, this is the best I can get it. The skips/workarounds can be addressed by followup PRs. Assuming it's good, let's get this in so I can backport it to the v4.6 branch (unless there's a reason not to?).

Copy link
Copy Markdown
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @cevich !

@sbrivio-rh
Copy link
Copy Markdown
Collaborator

Thanks @sbrivio-rh maybe he's on vacation or something. I just was able to check, and indeed it's still installing 0.0~git20230309.7c7625d-1. I'll wait for your word.

Behold, for 'tis my word. Debian unstable (sid) package is now updated to 0.0~git20230627.289301b-1.

Copy link
Copy Markdown
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

I would like to merge this ASAP, then deal with pasta-debian later. Whoever agrees, release the krakhold.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago, renovate[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Copy Markdown
Member

Luap99 commented Aug 3, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit da8e29b into main Aug 3, 2023
@renovate renovate bot deleted the renovate/major-ci-vm-image branch August 3, 2023 07:31
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies Pull requests that update a dependency file lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants