Skip to content

Fix e2e tests referencing generic env. var.#13934

Merged
openshift-merge-robot merged 1 commit intocontainers:mainfrom
cevich:fix_debug
Apr 21, 2022
Merged

Fix e2e tests referencing generic env. var.#13934
openshift-merge-robot merged 1 commit intocontainers:mainfrom
cevich:fix_debug

Conversation

@cevich
Copy link
Copy Markdown
Member

@cevich cevich commented Apr 20, 2022

Use of $DEBUG is highly likely to clash. Fortunately this one is in
a very specific/special context, so a rename fix should be perfectly
adequate.

See also containers/automation#96
and #13932

Signed-off-by: Chris Evich cevich@redhat.com

Use of `$DEBUG` is highly likely to clash.  Fortunately this one is in
a very specific/special context, so a rename fix should be perfectly
adequate.

See also containers/automation#96
and containers#13932

Signed-off-by: Chris Evich <cevich@redhat.com>
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Apr 20, 2022

/approve
LGTM

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2022
@TomSweeneyRedHat
Copy link
Copy Markdown
Member

LGTM

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2022
@openshift-merge-robot openshift-merge-robot merged commit 02ab86a into containers:main Apr 21, 2022
@cevich cevich deleted the fix_debug branch April 18, 2023 14:50
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants