Fix use of overly generic DEBUG env. var.#96
Merged
cevich merged 1 commit intocontainers:mainfrom Apr 20, 2022
Merged
Conversation
cevich
added a commit
to cevich/automation_images
that referenced
this pull request
Apr 20, 2022
Companion to containers/automation#96 Signed-off-by: Chris Evich <cevich@redhat.com>
It was an unfortunate mistake to name this variable as such. It was observed to collide with other non-conforming usages in downstream. This was esp. leading to some difficult to debug situations, such as containers/podman#13932 The common automation library is used far/wide by many environments, which unfortunately may also rely on a generic `$DEBUG`. Fix the issue here, by renaming the variable. Let this serve as a warning to all downstream, everywhere: ***Avoid all use of similar generic variable names, make them context-specific!*** Signed-off-by: Chris Evich <cevich@redhat.com>
|
Successfully triggered github-actions/success task to indicate successful run of cirrus-ci_retrospective integration and unit testing from this PR's 0aeebaab8a3302967fc6375e145819352b640c0a. |
cevich
added a commit
to cevich/podman
that referenced
this pull request
Apr 20, 2022
Use of `$DEBUG` is highly likely to clash. Fortunately this one is in a very specific/special context, so a rename fix should be perfectly adequate. See also containers/automation#96 and containers#13932 Signed-off-by: Chris Evich <cevich@redhat.com>
|
Successfully triggered github-actions/success task to indicate successful run of cirrus-ci_retrospective integration and unit testing from this PR's 7dfa5d11e4beb32104d9f118e74fd9aa14a89244. |
cevich
added a commit
to cevich/automation_images
that referenced
this pull request
Apr 28, 2022
Companion to containers/automation#96 Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/automation_images
that referenced
this pull request
Apr 28, 2022
Companion to containers/automation#96 Signed-off-by: Chris Evich <cevich@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was an unfortunate mistake to name this variable as such. It was
observed to collide with other non-conforming usages in downstream.
This was esp. leading to some difficult to debug situations, such as
containers/podman#13932 The common
automation library is used far/wide by many environments, which
unfortunately may also rely on a generic
$DEBUG. Fix the issue here,by renaming the variable.
Let this serve as a warning to all downstream, everywhere: Avoid all
use of similar generic variable names, make them context-specific!
Signed-off-by: Chris Evich cevich@redhat.com