… meaning that callers who intend to submit an image reference, and don’t specifically filter out "", get unexpected behavior.
At least, document this special case (and perhaps audit other NewReference* functions for possible other instances of this).
Arguably:
NewIndexReference should be modified to actually reject an “N/A” index value <0
NewTagReference should be added, where passing "" is an error.
… meaning that callers who intend to submit an image reference, and don’t specifically filter out
"", get unexpected behavior.At least, document this special case (and perhaps audit other
NewReference*functions for possible other instances of this).Arguably:
NewIndexReferenceshould be modified to actually reject an “N/A” index value <0NewTagReferenceshould be added, where passing""is an error.