Improve handling and documentation of various transport reference corner cases#2767
Merged
mtrmac merged 6 commits intocontainers:mainfrom Mar 11, 2025
Merged
Improve handling and documentation of various transport reference corner cases#2767mtrmac merged 6 commits intocontainers:mainfrom
mtrmac merged 6 commits intocontainers:mainfrom
Conversation
Should not change (test) behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
They can't be used anyway (destinations require a reference, and sources panic), so fail cleanly. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Reject NewIndexReference with a "missing" index value of -1; callers can use the other NewReference instead. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…andled specially Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
The same thing is already said a few lines below. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
d61dcc0 to
67490ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.
(Minimally) fixes #2679 .