Skip to content

CI VMs: bump, to debian with cgroups v2#5550

Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
edsantiago:debian-modernize
Jun 3, 2024
Merged

CI VMs: bump, to debian with cgroups v2#5550
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
edsantiago:debian-modernize

Conversation

@edsantiago
Copy link
Member

Per consent in 2024-03-20 Planning, remove support for cgroups v1.
And, per discovery on 2024-05-28, systemd 256 no longer even
boots on a cgroups v1 system.

This commit switches to VMs built in:

containers/automation_images#338

...in which Debian is now cgroups v2 with crun.

Signed-off-by: Ed Santiago santiago@redhat.com

None

@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@edsantiago
Copy link
Member Author

@containers/buildah-maintainers PTAL, this is important for gating tests, and for podman bud tests, and for getting rid of cgroups v1.

@nalind if you can offer me a quick fix for the commented-out tests, I'd love that, otherwise I'll file issues.

@lsm5
Copy link
Member

lsm5 commented May 29, 2024

rawhide build failures are unrelated and should be fixed automatically on the infra side soon. Ignore for now

Per consent in 2024-03-20 Planning, remove support for cgroups v1.
And, per discovery on 2024-05-28, systemd 256 no longer even
boots on a cgroups v1 system.

This commit switches to VMs built in:

  containers/automation_images#338

...in which Debian is now cgroups v2 with crun.

Requires disabling two conformance tests which fail when run
against docker 26.1; see containers#5526 for context on those.

Also requires disabling two bats tests on debian because
something changed there in ulimits. I'll look into them
later but right now this gives us breathing space.

And, latest git on f40 refuses to serve non-root files when
run as root ("dubious ownership"); so, in start_git_daemon(),
chown the extracted files.

Signed-off-by: Ed Santiago <santiago@redhat.com>
@edsantiago
Copy link
Member Author

@containers/buildah-maintainers please merge when convenient.

  • docker tests: will need to be fixed by @nalind some day
  • bats tests (the debian ulimit thing): I've looked into it on a ci-vm, have not been able to figure it out, am quitting for today and will look again tomorrow with a fresh brain.
  • the git fix is necessary because VM images have a new git which throws new errors when root serves non-root files.

@edsantiago
Copy link
Member Author

ping

edsantiago added a commit to edsantiago/buildah that referenced this pull request Jun 3, 2024
Basically, git 2.45 adds security stuff that breaks our tests.

Pulled from containers#5550 in hopes that we can get this merged ASAP
because it keeps breaking gating tests.

Signed-off-by: Ed Santiago <santiago@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Jun 3, 2024

/approve
lgtm

@openshift-ci openshift-ci bot added the approved label Jun 3, 2024
@rhatdan
Copy link
Member

rhatdan commented Jun 3, 2024

@cevich @lsm5 @nalind @giuseppe PTAL

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will defer to others for final review.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, lsm5, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Jun 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8b4ec1b into containers:main Jun 3, 2024
@edsantiago edsantiago deleted the debian-modernize branch June 3, 2024 18:27
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants