Debian: remove force-cgroups-v1 code by edsantiago · Pull Request #338 · containers/automation_images

edsantiago · 2024-03-20T17:21:23Z

Per discussion in 2024-03-20 Planning meeting, we will no
longer be testing runc in CI. And cgroups V1 is dead too.

Signed-off-by: Ed Santiago santiago@redhat.com

github-actions · 2024-03-20T18:39:22Z

Cirrus CI build successful. Found built image names and IDs:

Stage	Image Name	`IMAGE_SUFFIX`
base	debian	`do-not-use`
base	fedora	`do-not-use`
base	fedora-aws	`do-not-use`
base	fedora-aws-arm64	`do-not-use`
base	image-builder	`do-not-use`
base	prior-fedora	`do-not-use`
cache	build-push	`c20240320t171843z-f39f38d13`
cache	debian	`c20240320t171843z-f39f38d13`
cache	fedora	`c20240320t171843z-f39f38d13`
cache	fedora-aws	`c20240320t171843z-f39f38d13`
cache	fedora-netavark	`c20240320t171843z-f39f38d13`
cache	fedora-netavark-aws-arm64	`c20240320t171843z-f39f38d13`
cache	fedora-podman-aws-arm64	`c20240320t171843z-f39f38d13`
cache	fedora-podman-py	`c20240320t171843z-f39f38d13`
cache	prior-fedora	`c20240320t171843z-f39f38d13`
cache	rawhide	`c20240320t171843z-f39f38d13`
cache	win-server-wsl	`c20240320t171843z-f39f38d13`

github-actions · 2024-03-20T18:39:33Z

Cirrus CI build successful. Found built image names and IDs:

Stage	Image Name	`IMAGE_SUFFIX`
base	debian	`do-not-use`
base	fedora	`do-not-use`
base	fedora-aws	`do-not-use`
base	fedora-aws-arm64	`do-not-use`
base	image-builder	`do-not-use`
base	prior-fedora	`do-not-use`
cache	build-push	`c20240320t171843z-f39f38d13`
cache	debian	`c20240320t171843z-f39f38d13`
cache	fedora	`c20240320t171843z-f39f38d13`
cache	fedora-aws	`c20240320t171843z-f39f38d13`
cache	fedora-netavark	`c20240320t171843z-f39f38d13`
cache	fedora-netavark-aws-arm64	`c20240320t171843z-f39f38d13`
cache	fedora-podman-aws-arm64	`c20240320t171843z-f39f38d13`
cache	fedora-podman-py	`c20240320t171843z-f39f38d13`
cache	prior-fedora	`c20240320t171843z-f39f38d13`
cache	rawhide	`c20240320t171843z-f39f38d13`
cache	win-server-wsl	`c20240320t171843z-f39f38d13`

edsantiago · 2024-03-20T18:50:31Z

[Packages are identical to #338]

edsantiago · 2024-03-20T19:56:58Z

Well, this is not going to be easy.

github-actions · 2024-03-20T20:54:54Z

Cirrus CI build successful. Found built image names and IDs:

Stage	Image Name	`IMAGE_SUFFIX`
base	debian	`do-not-use`
base	fedora	`do-not-use`
base	fedora-aws	`do-not-use`
base	fedora-aws-arm64	`do-not-use`
base	image-builder	`do-not-use`
base	prior-fedora	`do-not-use`
cache	build-push	`c20240320t193412z-f39f38d13`
cache	debian	`c20240320t193412z-f39f38d13`
cache	fedora	`c20240320t193412z-f39f38d13`
cache	fedora-aws	`c20240320t193412z-f39f38d13`
cache	fedora-netavark	`c20240320t193412z-f39f38d13`
cache	fedora-netavark-aws-arm64	`c20240320t193412z-f39f38d13`
cache	fedora-podman-aws-arm64	`c20240320t193412z-f39f38d13`
cache	fedora-podman-py	`c20240320t193412z-f39f38d13`
cache	prior-fedora	`c20240320t193412z-f39f38d13`
cache	rawhide	`c20240320t193412z-f39f38d13`
cache	win-server-wsl	`c20240320t193412z-f39f38d13`

github-actions · 2024-05-14T14:55:34Z

Cirrus CI build successful. Found built image names and IDs:

Stage	Image Name	`IMAGE_SUFFIX`
base	debian	`do-not-use`
base	fedora	`do-not-use`
base	fedora-aws	`do-not-use`
base	fedora-aws-arm64	`do-not-use`
base	image-builder	`do-not-use`
base	prior-fedora	`do-not-use`
cache	build-push	`c20240514t134014z-f40f39d13`
cache	debian	`c20240514t134014z-f40f39d13`
cache	fedora	`c20240514t134014z-f40f39d13`
cache	fedora-aws	`c20240514t134014z-f40f39d13`
cache	fedora-netavark	`c20240514t134014z-f40f39d13`
cache	fedora-netavark-aws-arm64	`c20240514t134014z-f40f39d13`
cache	fedora-podman-aws-arm64	`c20240514t134014z-f40f39d13`
cache	fedora-podman-py	`c20240514t134014z-f40f39d13`
cache	prior-fedora	`c20240514t134014z-f40f39d13`
cache	rawhide	`c20240514t134014z-f40f39d13`
cache	win-server-wsl	`c20240514t134014z-f40f39d13`

edsantiago · 2024-05-14T14:58:10Z

20240514t134014z-f40f39d13
20240513t140131z-f40f39d13 ⇑ (built in debian: use tmpfs on /tmp + bump /tmp size on fedora #351)

	debian	prior-fedora	fedora	fedora-aws	rawhide
kernel	6.7.12-1	6.8.9-200	6.8.9-300	6.8.9-300	6.9.0-64
					6.9.0-0.rc7.20240510git448b3fe5a0ea.62 ⇑
container-selinux	?	2.231.0-1	2.231.0-1	2.230.0-1	2.231.0-1
		2.230.0-1 ⇑
passt	2024-04-26	2024-04-26	2024-05-10	2024-05-10	2024-05-10
				2024-04-26 ⇑
podman	4.9.4+ds1-1	4.9.4-1	5.0.3-1	5.0.2-1	5.0.3-1
					5.0.2-1 ⇑
systemd	255.5-1	254.10-1	255.6-1	255.6-1	256~rc1^20240509git1781de1-2
					255.5-1 ⇑

edsantiago · 2024-05-28T14:42:15Z

@containers/podman-maintainers looks like our days of testing cgroups v1 are numbered. New debian VMs are bringing in new systemd, which refuses to boot under cgroups v1. See #355 for further details.

mheon · 2024-05-28T14:44:04Z

I think that's OK now. We don't release to RHEL8 anymore. 9 can switch to CGv1 but it's not the default. 5 officially deprecated CGv1 support.

edsantiago · 2024-05-28T14:46:39Z

it's okay, and (per commit message) this was agreed to on March 20 in Planning, but podman tests are going to need some surgery and I've let that slide. Fortunately I have nothing else going on this week[1] so I'll get on that ASAP.

[1] joke. not a funny one.

Luap99 · 2024-05-28T14:48:29Z

Think of the all the v1/v2 conditionals that we can remove in the tests and eventually the code as well

github-actions · 2024-05-28T21:10:34Z

Cirrus CI build successful. Found built image names and IDs:

Stage	Image Name	`IMAGE_SUFFIX`
base	debian	`do-not-use`
base	fedora	`do-not-use`
base	fedora-aws	`do-not-use`
base	fedora-aws-arm64	`do-not-use`
base	image-builder	`do-not-use`
base	prior-fedora	`do-not-use`
cache	build-push	`c20240528t194313z-f40f39d13`
cache	debian	`c20240528t194313z-f40f39d13`
cache	fedora	`c20240528t194313z-f40f39d13`
cache	fedora-aws	`c20240528t194313z-f40f39d13`
cache	fedora-netavark	`c20240528t194313z-f40f39d13`
cache	fedora-netavark-aws-arm64	`c20240528t194313z-f40f39d13`
cache	fedora-podman-aws-arm64	`c20240528t194313z-f40f39d13`
cache	fedora-podman-py	`c20240528t194313z-f40f39d13`
cache	prior-fedora	`c20240528t194313z-f40f39d13`
cache	rawhide	`c20240528t194313z-f40f39d13`
cache	win-server-wsl	`c20240528t194313z-f40f39d13`

As agreed in Planning meeting of 2024-03-20, Podman 5.x will drop support for cgroups v1 and for runc. Make it so. CI images built in containers/automation_images#338 Signed-off-by: Ed Santiago <santiago@redhat.com>

Per consent in 2024-03-20 Planning, remove support for cgroups v1. And, per discovery on 2024-05-28, systemd 256 no longer even boots on a cgroups v1 system. This commit switches to VMs built in: containers/automation_images#338 ...in which Debian is now cgroups v2 with crun. Signed-off-by: Ed Santiago <santiago@redhat.com>

Per consent in 2024-03-20 Planning, remove support for cgroups v1. And, per discovery on 2024-05-28, systemd 256 no longer even boots on a cgroups v1 system. This commit switches to VMs built in: containers/automation_images#338 ...in which Debian is now cgroups v2 with crun. Requires disabling two conformance tests which fail when run against docker 26.1; see containers#5526 for context on those. And, latest git on f40 refuses to serve non-root files when run as root ("dubious ownership"); so, in start_git_daemon(), chown the extracted files. Signed-off-by: Ed Santiago <santiago@redhat.com>

edsantiago · 2024-05-29T11:30:45Z

20240528t194313z-f40f39d13
20240513t140131z-f40f39d13 ⇑ (built in debian: use tmpfs on /tmp + bump /tmp size on fedora #351)

	debian	prior-fedora	fedora	fedora-aws	rawhide
kernel	6.8.11-1	6.8.10-200	6.8.5-301	6.8.5-301	6.9.0-64
	6.7.12-1 ⇑	6.8.9-200 ⇑	6.8.9-300 ⇑	6.8.9-300 ⇑	6.9.0-0.rc7.20240510git448b3fe5a0ea.62 ⇑
buildah	1.33.7+ds1-1	1.35.4-1	1.36.0-1	1.35.4-1	1.35.4-1
		1.35.3-1 ⇑	1.35.4-1 ⇑	1.35.3-1 ⇑
conmon	2.1.10+ds1-1+b1	2.1.10-1	2.1.12-1	2.1.10-1	2.1.10-1
			2.1.10-1 ⇑
container-selinux	?	2.231.0-1	2.231.0-1	2.231.0-1	2.231.0-6
		2.230.0-1 ⇑		2.230.0-1 ⇑	2.231.0-1 ⇑
containers-common	?	1-99	0.59.0-1	0.58.0-2	0.59.0-1
			0.58.0-2 ⇑		0.58.0-18 ⇑
crun	1.15-1	1.15-1	1.15-1	1.15-1	1.15-1
		1.14.4-1 ⇑		1.14.4-1 ⇑
docker-ce	5:26.1.3-1~~debian.12~~bookworm	?	?	?	?
	5:26.1.2-1~~debian.12~~bookworm ⇑
golang	2:1.22~3	1.21.10-1	1.22.3-1	1.22.3-1	1.22.3-1
		1.21.9-1 ⇑		1.22.2-1 ⇑
passt	2024-04-26	2024-05-10	2024-05-10	2024-05-10	2024-05-23
		2024-04-26 ⇑		2024-04-26 ⇑	2024-05-10 ⇑
podman	4.9.4+ds1-1	4.9.4-1	5.1.0~rc1-1	5.0.3-1	5.0.3-1
			5.0.3-1 ⇑	5.0.2-1 ⇑	5.0.2-1 ⇑
skopeo	1.13.3+ds1-2+b1	1.15.0-1	1.15.1-1	1.15.0-1	1.15.1-1
			1.15.0-1 ⇑		1.15.0-1 ⇑
systemd	256~rc3-4	254.12-1	255.7-1	255.6-1	256~rc3-1
	255.5-1 ⇑	254.10-1 ⇑	255.6-1 ⇑		255.5-1 ⇑

edsantiago · 2024-05-29T14:10:24Z

sigh.....

Per discussion in 2024-03-20 Planning meeting, we will no longer be testing runc in CI. And cgroups V1 is dead too. Signed-off-by: Ed Santiago <santiago@redhat.com>

It has been retired in Rawhide, and it's unclear whether we need it at all. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

plocate is the default locate implementation in Fedora. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

cevich

Thanks for taking care of this Ed.

> panic: encoding alphabet includes duplicate symbols Signed-off-by: Miloslav Trmač <mitr@redhat.com>

github-actions · 2024-05-29T15:35:30Z

Cirrus CI build successful. Found built image names and IDs:

Stage	Image Name	`IMAGE_SUFFIX`
base	debian	`do-not-use`
base	fedora	`do-not-use`
base	fedora-aws	`do-not-use`
base	fedora-aws-arm64	`do-not-use`
base	image-builder	`do-not-use`
base	prior-fedora	`do-not-use`
cache	build-push	`c20240529t141726z-f40f39d13`
cache	debian	`c20240529t141726z-f40f39d13`
cache	fedora	`c20240529t141726z-f40f39d13`
cache	fedora-aws	`c20240529t141726z-f40f39d13`
cache	fedora-netavark	`c20240529t141726z-f40f39d13`
cache	fedora-netavark-aws-arm64	`c20240529t141726z-f40f39d13`
cache	fedora-podman-aws-arm64	`c20240529t141726z-f40f39d13`
cache	fedora-podman-py	`c20240529t141726z-f40f39d13`
cache	prior-fedora	`c20240529t141726z-f40f39d13`
cache	rawhide	`c20240529t141726z-f40f39d13`
cache	win-server-wsl	`c20240529t141726z-f40f39d13`

edsantiago · 2024-05-29T15:37:14Z

20240529t141726z-f40f39d13
20240528t194313z-f40f39d13 ⇑ (built in Debian: remove force-cgroups-v1 code #338)

	debian	prior-fedora	fedora	fedora-aws	rawhide
systemd	256~rc3-5	254.12-1	255.7-1	255.7-1	256~rc3-1
	256~rc3-4 ⇑			255.6-1 ⇑

Per consent in 2024-03-20 Planning, remove support for cgroups v1. And, per discovery on 2024-05-28, systemd 256 no longer even boots on a cgroups v1 system. This commit switches to VMs built in: containers/automation_images#338 ...in which Debian is now cgroups v2 with crun. Requires disabling two conformance tests which fail when run against docker 26.1; see containers#5526 for context on those. Also requires disabling two bats tests on debian because something changed there in ulimits. I'll look into them later but right now this gives us breathing space. And, latest git on f40 refuses to serve non-root files when run as root ("dubious ownership"); so, in start_git_daemon(), chown the extracted files. Signed-off-by: Ed Santiago <santiago@redhat.com>

Another new-VM import from containers/automation_images#338 ...because the usual conflict dealio in that repo. This should mostly be a NOP. All the major work was done in containers#22706. Signed-off-by: Ed Santiago <santiago@redhat.com>

@mtrmac

Changes: - fix from @mtrmac for go-1.22 panic ("alphabet, duplicate symbols") - debian is now cgroupsv2 + crun (does not affect skopeo) - many other Red Queen fixes Built in: containers/automation_images#338 Signed-off-by: Ed Santiago <santiago@redhat.com>

edsantiago · 2024-05-29T17:46:02Z

CI is passing in podman, buildah, and skopeo.

edsantiago · 2024-05-29T18:18:35Z

@cevich if you have a moment could you please give a final once-over and then merge? My change is in e509909, all other commits are @mtrmac's from #355. I would like to tag this once it merges. TIA.

cevich

LGTM, thanks for seeing this through. In my mind at least, there's a bunch of comments and code in podman CI that (when using these images) will confusingly suggest CGv1 is in use. Are there any "cgroupsv1" cleanup/followup issues or cards that need creating?

edsantiago · 2024-05-29T18:40:44Z

Thank you. Yes, there will be a ton of cleanup needed to remove special-case conditionals. I've chosen not to tackle that yet.

cevich · 2024-05-29T19:23:15Z

I've chosen not to tackle that yet.

That's fine, I or someone else may be able to help with this. I just wanted to know if you had already opened an issue/card or set a personal reminder. I'll go ahead and file a Jira card.

edsantiago mentioned this pull request Mar 20, 2024

New VM build, just to see how things are #337

Merged

edsantiago force-pushed the debian_cgroups_v2 branch from 52e8fc2 to 9c2d6e8 Compare March 20, 2024 19:34

edsantiago marked this pull request as draft March 20, 2024 19:56

edsantiago force-pushed the debian_cgroups_v2 branch from 9c2d6e8 to 7529bf0 Compare May 14, 2024 13:41

edsantiago marked this pull request as ready for review May 14, 2024 19:58

edsantiago mentioned this pull request May 14, 2024

Debian: switch to crun and cgroups v2 containers/podman#22706

Merged

edsantiago mentioned this pull request May 28, 2024

Test https://github.com/containers/automation_images/pull/355 containers/podman#22820

Closed

edsantiago force-pushed the debian_cgroups_v2 branch from 7529bf0 to b27b1a2 Compare May 28, 2024 14:34

edsantiago mentioned this pull request May 28, 2024

Skopeo: Backport a patch to avoid a panic when compiled with Go >= 1.22 #355

Closed

edsantiago force-pushed the debian_cgroups_v2 branch from b27b1a2 to 3fdfa74 Compare May 28, 2024 19:43

edsantiago mentioned this pull request May 29, 2024

CI VMs: bump, to debian with cgroups v2 containers/buildah#5550

Merged

edsantiago and others added 3 commits May 29, 2024 08:10

Debian: remove force-cgroups-v1 code

e509909

Per discussion in 2024-03-20 Planning meeting, we will no longer be testing runc in CI. And cgroups V1 is dead too. Signed-off-by: Ed Santiago <santiago@redhat.com>

Stop installing mlocate

6cbfbba

It has been retired in Rawhide, and it's unclear whether we need it at all. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

Also stop plocate-updatedb

564b76c

plocate is the default locate implementation in Fedora. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

edsantiago force-pushed the debian_cgroups_v2 branch from 3fdfa74 to 564b76c Compare May 29, 2024 14:11

cevich approved these changes May 29, 2024

View reviewed changes

Backport a patch to avoid a panic when compiled with Go >= 1.22

1e2559b

> panic: encoding alphabet includes duplicate symbols Signed-off-by: Miloslav Trmač <mitr@redhat.com>

edsantiago mentioned this pull request May 29, 2024

Sigh, new VMs again containers/podman#22838

Merged

edsantiago mentioned this pull request May 29, 2024

CI: bump VMs containers/skopeo#2342

Merged

cevich approved these changes May 29, 2024

View reviewed changes

cevich merged commit f7bdd13 into containers:main May 29, 2024

edsantiago deleted the debian_cgroups_v2 branch May 29, 2024 18:39

This was referenced Jun 6, 2024

Create a local registry #357

Merged

Windows: install dotnet and latest wix #354

Merged

cevich mentioned this pull request Jun 17, 2024

CI Cleanup: Remove cgroups v1 & runc support containers/podman#23020

Merged

edsantiago mentioned this pull request Jun 20, 2024

Semiregular VM catchup #361

Merged

Conversation

edsantiago commented Mar 20, 2024

Uh oh!

github-actions bot commented Mar 20, 2024

Uh oh!

github-actions bot commented Mar 20, 2024

Uh oh!

edsantiago commented Mar 20, 2024

Uh oh!

edsantiago commented Mar 20, 2024

Uh oh!

github-actions bot commented Mar 20, 2024

Uh oh!

github-actions bot commented May 14, 2024

Uh oh!

edsantiago commented May 14, 2024

Uh oh!

edsantiago commented May 28, 2024

Uh oh!

mheon commented May 28, 2024

Uh oh!

edsantiago commented May 28, 2024

Uh oh!

Luap99 commented May 28, 2024

Uh oh!

github-actions bot commented May 28, 2024

Uh oh!

edsantiago commented May 29, 2024

Uh oh!

edsantiago commented May 29, 2024

Uh oh!

cevich left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 29, 2024

Uh oh!

edsantiago commented May 29, 2024

Uh oh!

edsantiago commented May 29, 2024

Uh oh!

edsantiago commented May 29, 2024

Uh oh!

cevich left a comment

Choose a reason for hiding this comment

Uh oh!

edsantiago commented May 29, 2024

Uh oh!

cevich commented May 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants