imagebuildah: set len(short_image_id) to 12#4660
Merged
rhatdan merged 1 commit intocontainers:mainfrom Mar 18, 2023
Merged
Conversation
Member
|
Can you add LGTM |
Member
TomSweeneyRedHat
left a comment
There was a problem hiding this comment.
LGTM once the tests are hip
Thanks @danishprakash !
Collaborator
|
LGTM but a small test will ensure we don't regress this accidentally again in future. |
fd680ca to
8c501e6
Compare
* tests/bud.bats: add test Signed-off-by: danishprakash <danish.prakash@suse.com>
8c501e6 to
b6f32e5
Compare
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danishprakash, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Apr 10, 2023
After containers/buildah#4660 buildah spits a 12 letter image short id instead of 13 so lets honor that. Signed-off-by: Aditya R <arajan@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Buildah bud prints a 11-digit hash during build unlike docker, which dumps a 12-digit hash. Further looking at the relevant commit, this looks like a typo since the commit clearly intends to dump the 12-digit hash aiming for parity with docker.
Refers containers/podman#5012 & #2124
Does this PR introduce a user-facing change?
Signed-off-by: danishprakash danish.prakash@suse.com