Make the commit id clear like Docker by TomSweeneyRedHat · Pull Request #2124 · containers/buildah

TomSweeneyRedHat · 2020-01-30T17:53:10Z

Using this Dockerfile:

FROM alpine AS tommer

Docker does:

Sending build context to Docker daemon  17.92kB
Step 1/1 : FROM alpine AS tommer
latest: Pulling from library/alpine
c9b1b535fdd9: Pull complete
Digest: sha256:ab00606a42621fb68f2ed6ad3c88be54397f981a7b70a79db3d1172b11c4367d
Status: Downloaded newer image for alpine:latest
 ---> e7d92cdc71fe
Successfully built e7d92cdc71fe

While Buildah does:

STEP 1: FROM alpine AS tommer
STEP 2: COMMIT tom
e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a
e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a

Per user requests, we've over time eliminated some of the "noisier" output that
Docker has, and that's now led to some confusion when we show an intermediate
image id (after the commit) and then as in the case, the same final
image id immediately afterwards. We display only the full final image id to
make scripting easier per other user requests.

To aid with this, this pr will cause the intermediate image to be displayed
after an --> like Docker and will also show the 12 character short id.

If the --quiet option is used, this shorter id will not be displayed, only
the final longer one.

New behavior:

STEP 1: FROM alpine AS tommer
STEP 2: COMMIT tom
--> e7d92cdc71f
e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a

Fixes: containers/podman#5012

TomSweeneyRedHat · 2020-01-30T17:54:05Z

@vrothberg fyi and/or PTAL

TomSweeneyRedHat · 2020-01-30T17:55:21Z

imagebuildah/executor.go

 		return "", nil, err
 	}
-
+	logrus.Debugf("printing final image id %q", imageID)


I've added this debug in my own self interest. This is the 3rd time in the past few months that I've spent 10 or more minutes looking for where the final image id is printed in the code. Hopefully going forward I'll remember to run the bud command in debug and will be able to locate it more quickly.

TomSweeneyRedHat · 2020-01-30T18:40:44Z

imagebuildah/stage_executor.go

 	logImageID := func(imgID string) {
 		if s.executor.iidfile == "" {
-			fmt.Fprintf(s.executor.out, "%s\n", imgID)
+			fmt.Fprintf(s.executor.out, "--> %s\n", imgID[0:11])


ooops, forgot a length check, will add .

rhatdan · 2020-02-02T15:46:55Z

Are there any man page examples that need to be updated?

vrothberg

Other than Dan's man page question, LGTM 👍 Thanks for the ping!

TomSweeneyRedHat · 2020-02-06T00:55:45Z

We don't list the output of the build commands in the man page that I can see. In the tutorials we list some of it, but remove most of the output with a "{output removed for brevity}" kind of tag. So I don't think there are any changes to be made as far as that's concerned.

vrothberg · 2020-02-06T08:22:13Z

@rh-atomic-bot r+

rh-atomic-bot · 2020-02-06T08:22:15Z

📌 Commit f277e48 has been approved by vrothberg

rh-atomic-bot · 2020-02-06T08:22:23Z

⌛ Testing commit f277e48 with merge b477cba...

Using this Dockerfile: ``` FROM alpine AS tommer ``` Docker does: ``` Sending build context to Docker daemon 17.92kB Step 1/1 : FROM alpine AS tommer latest: Pulling from library/alpine c9b1b535fdd9: Pull complete Digest: sha256:ab00606a42621fb68f2ed6ad3c88be54397f981a7b70a79db3d1172b11c4367d Status: Downloaded newer image for alpine:latest ---> e7d92cdc71fe Successfully built e7d92cdc71fe ``` While Buildah does: ``` STEP 1: FROM alpine AS tommer STEP 2: COMMIT tom e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a ``` Per user requests, we've over time eliminateed some of the "noisier" output that Docker has, and that's now led to some confusion when we show an intermediate image id (after the commit) and then as in the case, the same final image id immediately afterwards. We display only the full final image id to make scripting easier per other user requests. To aid with this, this pr will cause the intermediate image to be displayed after an `-->` like Docker and will also show the 12 character short id. If the `--quiet` option is used, this shorter id will not be displayed, only the final longer one. New behavior: ``` STEP 1: FROM alpine AS tommer STEP 2: COMMIT tom --> e7d92cdc71f e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a ``` Fixes: containers/podman#5012 Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Closes: #2124 Approved by: vrothberg

rh-atomic-bot · 2020-02-06T08:56:14Z

💔 Test failed - status-travis

vrothberg · 2020-02-06T09:02:29Z

@rh-atomic-bot retry

rh-atomic-bot · 2020-02-06T09:02:40Z

⌛ Testing commit f277e48 with merge 5e5d19e...

Using this Dockerfile: ``` FROM alpine AS tommer ``` Docker does: ``` Sending build context to Docker daemon 17.92kB Step 1/1 : FROM alpine AS tommer latest: Pulling from library/alpine c9b1b535fdd9: Pull complete Digest: sha256:ab00606a42621fb68f2ed6ad3c88be54397f981a7b70a79db3d1172b11c4367d Status: Downloaded newer image for alpine:latest ---> e7d92cdc71fe Successfully built e7d92cdc71fe ``` While Buildah does: ``` STEP 1: FROM alpine AS tommer STEP 2: COMMIT tom e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a ``` Per user requests, we've over time eliminateed some of the "noisier" output that Docker has, and that's now led to some confusion when we show an intermediate image id (after the commit) and then as in the case, the same final image id immediately afterwards. We display only the full final image id to make scripting easier per other user requests. To aid with this, this pr will cause the intermediate image to be displayed after an `-->` like Docker and will also show the 12 character short id. If the `--quiet` option is used, this shorter id will not be displayed, only the final longer one. New behavior: ``` STEP 1: FROM alpine AS tommer STEP 2: COMMIT tom --> e7d92cdc71f e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a ``` Fixes: containers/podman#5012 Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Closes: #2124 Approved by: vrothberg

rh-atomic-bot · 2020-02-06T09:09:05Z

💔 Test failed - status-papr

TomSweeneyRedHat · 2020-02-07T20:30:19Z

I think I'll have a merge conflict with #2149. Once that's in I'll rebase and work on this one again.

Using this Dockerfile: ``` FROM alpine AS tommer ``` Docker does: ``` Sending build context to Docker daemon 17.92kB Step 1/1 : FROM alpine AS tommer latest: Pulling from library/alpine c9b1b535fdd9: Pull complete Digest: sha256:ab00606a42621fb68f2ed6ad3c88be54397f981a7b70a79db3d1172b11c4367d Status: Downloaded newer image for alpine:latest ---> e7d92cdc71fe Successfully built e7d92cdc71fe ``` While Buildah does: ``` STEP 1: FROM alpine AS tommer STEP 2: COMMIT tom e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a ``` Per user requests, we've over time eliminateed some of the "noisier" output that Docker has, and that's now led to some confusion when we show an intermediate image id (after the commit) and then as in the case, the same final image id immediately afterwards. We display only the full final image id to make scripting easier per other user requests. To aid with this, this pr will cause the intermediate image to be displayed after an `-->` like Docker and will also show the 12 character short id. If the `--quiet` option is used, this shorter id will not be displayed, only the final longer one. New behavior: ``` STEP 1: FROM alpine AS tommer STEP 2: COMMIT tom --> e7d92cdc71f e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a ``` Fixes: containers/podman#5012 Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>

rhatdan · 2020-02-12T10:19:04Z

bors r+

bors · 2020-02-12T10:19:07Z

👎 Rejected by too few approved reviews

rhatdan · 2020-02-13T10:08:03Z

bors retry

2124: Make the commit id clear like Docker r=rhatdan a=TomSweeneyRedHat Using this Dockerfile: ``` FROM alpine AS tommer ``` Docker does: ``` Sending build context to Docker daemon 17.92kB Step 1/1 : FROM alpine AS tommer latest: Pulling from library/alpine c9b1b535fdd9: Pull complete Digest: sha256:ab00606a42621fb68f2ed6ad3c88be54397f981a7b70a79db3d1172b11c4367d Status: Downloaded newer image for alpine:latest ---> e7d92cdc71fe Successfully built e7d92cdc71fe ``` While Buildah does: ``` STEP 1: FROM alpine AS tommer STEP 2: COMMIT tom e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a ``` Per user requests, we've over time eliminated some of the "noisier" output that Docker has, and that's now led to some confusion when we show an intermediate image id (after the commit) and then as in the case, the same final image id immediately afterwards. We display only the full final image id to make scripting easier per other user requests. To aid with this, this pr will cause the intermediate image to be displayed after an `-->` like Docker and will also show the 12 character short id. If the `--quiet` option is used, this shorter id will not be displayed, only the final longer one. New behavior: ``` STEP 1: FROM alpine AS tommer STEP 2: COMMIT tom --> e7d92cdc71f e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a ``` Fixes: containers/podman#5012 Co-authored-by: TomSweeneyRedHat <tsweeney@redhat.com>

bors · 2020-02-13T10:55:14Z

Build succeeded

cirrus-ci/success

TomSweeneyRedHat commented Jan 30, 2020

View reviewed changes

TomSweeneyRedHat force-pushed the dev/tsweeney/doubleid branch from c7eb9cc to f277e48 Compare January 30, 2020 18:45

vrothberg reviewed Feb 3, 2020

View reviewed changes

TomSweeneyRedHat force-pushed the dev/tsweeney/doubleid branch from f277e48 to bb03eb3 Compare February 11, 2020 17:24

vrothberg approved these changes Feb 12, 2020

View reviewed changes

bors bot merged commit bb03eb3 into containers:master Feb 13, 2020

TomSweeneyRedHat deleted the dev/tsweeney/doubleid branch April 4, 2020 17:19

danishprakash mentioned this pull request Mar 15, 2023

imagebuildah: set len(short_image_id) to 12 #4660

Merged

github-actions bot added the locked - please file new issue/PR label Oct 4, 2023

github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2023

Conversation

TomSweeneyRedHat commented Jan 30, 2020

Uh oh!

TomSweeneyRedHat commented Jan 30, 2020

Uh oh!

TomSweeneyRedHat Jan 30, 2020

Choose a reason for hiding this comment

Uh oh!

TomSweeneyRedHat Jan 30, 2020

Choose a reason for hiding this comment

Uh oh!

rhatdan commented Feb 2, 2020

Uh oh!

vrothberg left a comment

Choose a reason for hiding this comment

Uh oh!

TomSweeneyRedHat commented Feb 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vrothberg commented Feb 6, 2020

Uh oh!

rh-atomic-bot commented Feb 6, 2020

Uh oh!

rh-atomic-bot commented Feb 6, 2020

Uh oh!

rh-atomic-bot commented Feb 6, 2020

Uh oh!

vrothberg commented Feb 6, 2020

Uh oh!

rh-atomic-bot commented Feb 6, 2020

Uh oh!

rh-atomic-bot commented Feb 6, 2020

Uh oh!

TomSweeneyRedHat commented Feb 7, 2020

Uh oh!

rhatdan commented Feb 12, 2020

Uh oh!

bors bot commented Feb 12, 2020

Uh oh!

rhatdan commented Feb 13, 2020

Uh oh!

bors bot commented Feb 13, 2020

Build succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TomSweeneyRedHat commented Feb 6, 2020 •

edited

Loading