Cirrus: Fix defunct package metadata breaking cache#3562
Merged
openshift-merge-robot merged 1 commit intocontainers:mainfrom Oct 1, 2021
Merged
Cirrus: Fix defunct package metadata breaking cache#3562openshift-merge-robot merged 1 commit intocontainers:mainfrom
openshift-merge-robot merged 1 commit intocontainers:mainfrom
Conversation
During VM image build, a number of packages are downloaded but not installed, since they may interfere with some testing. Then at runtime, where required, the packages are installed from cache and used. However, between image build and runtime it's possible the repository contents change, which will invalidate the package cache. Since the `--no-download --ignore-missing` options were used, the install will fail. Ref: containers/automation_images#95 Fortunately, when it comes to the docker packages, no other dependencies are required and so `apt-get` isn't required. Switch to using a simple dpkg install command on the necessary files. If this ever breaks due to new dependencies, the list of files may simply be updated. Signed-off-by: Chris Evich <cevich@redhat.com>
Collaborator
|
LGTM |
Collaborator
|
/lgtm |
Collaborator
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 15, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 16, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Note: This requires using a customized Ubuntu image w/ restored docker packages in a cache directory - mistakenly removed during original image creation. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Nov 16, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Note: This requires using a customized Ubuntu image w/ restored docker packages in a cache directory - mistakenly removed during original image creation. Signed-off-by: Chris Evich <cevich@redhat.com>
openshift-merge-robot
added a commit
that referenced
this pull request
Nov 19, 2021
[1.22] Cirrus: Backport PR #3562 + reduce testing tasks
openshift-merge-robot
added a commit
that referenced
this pull request
Nov 19, 2021
[1.23] Cirrus: Backport PR #3562 + reduce testing tasks
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Dec 6, 2021
Same package metadata problem found to affect older release branch 'conformance' testing. Make use of a hand-customized Ubuntu image with manually downloaded (cached) docker packages. This is necessary to support execution of the conformance tests long-term. Signed-off-by: Chris Evich <cevich@redhat.com>
openshift-merge-robot
added a commit
that referenced
this pull request
Dec 7, 2021
[1.21] Cirrus: Backport PR #3562 + reduce testing tasks
This was referenced Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
During VM image build, a number of packages are downloaded but not
installed, since they may interfere with some testing. Then at runtime,
where required, the packages are installed from cache and used.
However, between image build and runtime it's possible the repository
contents change, which will invalidate the package cache. Since the
--no-download --ignore-missingoptions were used, the install willfail.
Ref: containers/automation_images#95
Fortunately, when it comes to the docker packages, no other dependencies
are required and so
apt-getisn't required. Switch to using a simpledpkg install command on the necessary files. If this ever breaks due
to new dependencies, the list of files may simply be updated.
How to verify it
The setup stage of the conformance tests will pass.
Which issue(s) this PR fixes:
Fixes containers/automation_images#95
Special notes for your reviewer:
Does this PR introduce a user-facing change?
None