Skip to content

[1.21] Cirrus: Backport PR #3562 + reduce testing tasks#3626

Merged
openshift-merge-robot merged 2 commits intocontainers:release-1.21from
cevich:1.21_fix_install
Dec 7, 2021
Merged

[1.21] Cirrus: Backport PR #3562 + reduce testing tasks#3626
openshift-merge-robot merged 2 commits intocontainers:release-1.21from
cevich:1.21_fix_install

Conversation

@cevich
Copy link
Copy Markdown
Member

@cevich cevich commented Nov 15, 2021

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Same package metadata problem found to affect older release branch
'conformance' testing.

How to verify it

The conformance test will pass

Which issue(s) this PR fixes:

Daily cron-jobs and all PRs against this branch will fail 'conformance' test.

Special notes for your reviewer:

This is a CI-only change with zero impact on buildah-code.

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. approved labels Nov 15, 2021
@cevich cevich marked this pull request as draft November 15, 2021 20:29
@cevich
Copy link
Copy Markdown
Member Author

cevich commented Nov 17, 2021

Opened #3632

@cevich cevich changed the title [1.21] Cirrus: Backport PR #3562 [1.21] Cirrus: Backport PR #3562 + reduce testing tasks Nov 19, 2021
@cevich
Copy link
Copy Markdown
Member Author

cevich commented Dec 2, 2021

Curiously, this one started passing in Cirrus-Cron. on Dec. 1st. That gives me hope that a VM-image hand-edit might be a viable option on this branch.

1 similar comment
@cevich
Copy link
Copy Markdown
Member Author

cevich commented Dec 2, 2021

Curiously, this one started passing in Cirrus-Cron. on Dec. 1st. That gives me hope that a VM-image hand-edit might be a viable option on this branch.

Same package metadata problem found to affect older release branch
'conformance' testing.

Make use of a hand-customized Ubuntu image with manually downloaded
(cached) docker packages.  This is necessary to support execution of the
conformance tests long-term.

Signed-off-by: Chris Evich <cevich@redhat.com>
This follows a long-standing practice here and across other containers
projects.  Over time, it's simply not worth developer/maintainer time to
debug old tests that may fail due to new/changing inputs.  Reduce down
to the bare minimum of tasks to keep CI on life-support while the need
for backports remains possible but unlikely.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich marked this pull request as ready for review December 6, 2021 19:17
@cevich
Copy link
Copy Markdown
Member Author

cevich commented Dec 6, 2021

Bingo! @nalind or @rhatdan I fixed this one. It took me half the damn day to hand-edit the image, but the docker packages are properly cached long-term, and conformance tests passing. This PR also puts the branch into long-term maintenance mode (for CI).

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Dec 7, 2021

/approve
/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d856a24 into containers:release-1.21 Dec 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm locked - please file new issue/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants