build: Add support for buildkit like `--mount=type=bind` by flouthoc · Pull Request #3548 · containers/buildah

flouthoc · 2021-09-28T11:24:05Z

Following commit adds support for using buildkit like --mount=type=bind with RUN statements.
Mounts created by --mount are transient in nature and only scoped to current RUN statements just like buildkit.

Example

FROM alpine
RUN --mount=type=bind,source=.,target=/mnt cat /mnt/input_file

PS: docs already have entry for this but it was never implemented.

Closes: #3217

openshift-ci · 2021-09-28T11:24:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [flouthoc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

flouthoc · 2021-09-28T11:37:19Z

@containers/buildah-maintainers @giuseppe @rhatdan @nalind @vrothberg PTAL

buildah.go

run_linux.go

TomSweeneyRedHat · 2021-09-29T14:29:18Z

All kinds of test unhappiness @flouthoc

flouthoc · 2021-09-29T15:32:44Z

@TomSweeneyRedHat I think its quay flakes

Edit: Some passed, some still flaky

flouthoc · 2021-09-30T08:43:26Z

resolved conflicts after recent commits in main

tests/bud.bats

flouthoc · 2021-10-01T12:22:03Z

@cevich @containers/buildah-maintainers I am not sure but looks like something is up with CI for Conformance test its failing for all the PR's with error Package containerd.io is not installed

run_linux.go

pkg/parse/parse.go

imagebuildah/stage_executor.go

run_linux.go

cevich · 2021-10-01T18:48:36Z

Opened #3560 to fix CI

tests/bud/buildkit-mount/Dockerfile

flouthoc · 2021-10-01T19:36:56Z

@nalind Added requested tests, I still need to implement rw for chroot isolation.

run.go

flouthoc · 2021-10-01T21:18:03Z

@nalind I think rw is already working properly for isolated chroot i have also written a test for rw on isolated chroot. With rw enabled user can write on bind files and changes are also reflected on host.

flouthoc · 2021-10-01T21:26:45Z

Rebasing after #3562

rhatdan · 2021-10-04T17:54:46Z

LGTM

Following commit adds support for using buildkit like `--mount=type=bind` with `RUN` statements. Mounts created by `--mount` are transient in nature and only scoped to current RUN statements. Signed-off-by: Aditya Rajan <arajan@redhat.com>

nalind · 2021-10-06T12:26:53Z

pkg/parse/parse.go

 			// Alias for "ro"
 			newMount.Options = append(newMount.Options, "ro")
-		case "shared", "rshared", "private", "rprivate", "slave", "rslave", "Z", "z":
+		case "shared", "rshared", "private", "rprivate", "slave", "rslave", "Z", "z", "U":


Do we have test coverage for the "U" flag when used here?

@nalind Mount code is being reused from volumes and tests for U is already added here https://github.com/containers/buildah/blob/main/tests/run.bats#L304 therefore I refrained from adding ownership test to prevent redundancy

nalind · 2021-10-06T12:27:10Z

Question about test coverage of the "U" flag, otherwise LGTM.

rhatdan · 2021-10-06T18:40:19Z

/lgtm

openshift-ci bot added the approved label Sep 28, 2021

flouthoc force-pushed the buildkit-mount-bind branch from 2029320 to 659d6c3 Compare September 28, 2021 11:26

flouthoc added the buildkit label Sep 28, 2021

nalind reviewed Sep 28, 2021

View reviewed changes

buildah.go Outdated Show resolved Hide resolved

TomSweeneyRedHat reviewed Sep 28, 2021

View reviewed changes

run_linux.go Outdated Show resolved Hide resolved

flouthoc marked this pull request as draft September 28, 2021 20:12

openshift-ci bot added the do-not-merge/work-in-progress label Sep 28, 2021

flouthoc force-pushed the buildkit-mount-bind branch 3 times, most recently from 8c78cd0 to aedfcb8 Compare September 29, 2021 07:06

flouthoc marked this pull request as ready for review September 29, 2021 07:08

openshift-ci bot removed the do-not-merge/work-in-progress label Sep 29, 2021

flouthoc force-pushed the buildkit-mount-bind branch from aedfcb8 to 7943032 Compare September 29, 2021 10:56

flouthoc force-pushed the buildkit-mount-bind branch 3 times, most recently from 084a36c to dbe2b46 Compare September 30, 2021 08:42

flouthoc force-pushed the buildkit-mount-bind branch from dbe2b46 to 5ad284f Compare September 30, 2021 11:11

TomSweeneyRedHat reviewed Sep 30, 2021

View reviewed changes

tests/bud.bats Outdated Show resolved Hide resolved

flouthoc force-pushed the buildkit-mount-bind branch from 5ad284f to 62c1da3 Compare October 1, 2021 07:22