Skip to content

move cmd/continuity to its own go module#200

Merged
estesp merged 5 commits into
containerd:mainfrom
thaJeztah:separate_cli
Apr 4, 2022
Merged

move cmd/continuity to its own go module#200
estesp merged 5 commits into
containerd:mainfrom
thaJeztah:separate_cli

Conversation

@thaJeztah

@thaJeztah thaJeztah commented Apr 1, 2022

Copy link
Copy Markdown
Member

this command-line is mostly used for testing and debugging, and its
dependencies should not be a dependency of the main module (library)

@thaJeztah

Copy link
Copy Markdown
Member Author

after this, we should consider removing the vendor directory as the main module is then a library

@thaJeztah

This comment was marked as outdated.

@thaJeztah thaJeztah force-pushed the separate_cli branch 5 times, most recently from d824335 to dc3b390 Compare April 1, 2022 21:54
@thaJeztah

Copy link
Copy Markdown
Member Author

I'll do a rebase (#198 was merged)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
this command-line is mostly used for testing and debugging, and its
dependencies should not be a dependency of the main module (library)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

Copy link
Copy Markdown
Member Author

rebased 👍 @kzys @dmcgowan PTAL if this LGTY

@estesp estesp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants