CI: resolve Go path before sudoing ; Remove deprecated io/ioutil (except ioutil.ReadDir) #198
Merged
Merged
Conversation
18df8b4 to
2b9d890
Compare
e523942 to
229d93a
Compare
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
See actions/setup-go issue 104 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
dmcgowan
approved these changes
Apr 1, 2022
thaJeztah
approved these changes
Apr 1, 2022
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM
we can probably look at replacing ioutil.ReadDir() as well (but fine for a follow up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accidentally we had been using Go 1.15 (?) when sudoing
This PR also removes the deprecated
io/ioutilpackage (exceptioutil.ReadDir) to ensure that we are using the correct version of Go.