Skip to content

Patch CVE jwt fulnerability#194

Closed
iorvd wants to merge 1 commit into
containerd:mainfrom
iorvd:main
Closed

Patch CVE jwt fulnerability#194
iorvd wants to merge 1 commit into
containerd:mainfrom
iorvd:main

Conversation

@iorvd

@iorvd iorvd commented Feb 1, 2022

Copy link
Copy Markdown

Preface:
There's a known vulnerability in github.com/dgrijalva/jwt-go - GHSA-w73w-5m7g-f7qc

This PR bumps github.com/spf13/cobra to v1.3.0 in order to remove the deprecated and vulnerable library from the list of dependencies.

@estesp

estesp commented Feb 1, 2022

Copy link
Copy Markdown
Member

Thanks for this contribution; can you sign your commit and force push this branch to update the PR? Thanks!

Signed-off-by: Oleksandr Prokopovych <o.prokopovych@protonmail.ch>
@iorvd

iorvd commented Feb 2, 2022

Copy link
Copy Markdown
Author

Thanks @estesp!

Linter suggests to replace the deprecated library with a new one:

SA1019: Package github.com/golang/protobuf/proto is deprecated:
Use the "google.golang.org/protobuf/proto" package instead.  (staticcheck)

However I'm not sure what to do about this so far as these packages have no common v1.5.2 version.

@chandumlg

Copy link
Copy Markdown

Any update on this PR?

@Polber

Polber commented Apr 1, 2022

Copy link
Copy Markdown

I linked this PR to issue #199 as this PR would solve the issues brought up. There are now 2 known security vulnerabilities in the issue I submitted, as well as the one brought up in this PR. Are there any updates on this PR?

@AkihiroSuda

AkihiroSuda commented Apr 1, 2022

Copy link
Copy Markdown
Member

There's a known vulnerability in github.com/dgrijalva/jwt-go - GHSA-w73w-5m7g-f7qc

This package is not actually consumed in the continuity repo: https://github.com/containerd/continuity/tree/main/vendor/github.com

So, we are not prioritizing this PR, but we are happy to merge this when it passes CI

@estesp

estesp commented Apr 4, 2022

Copy link
Copy Markdown
Member

cobra has been removed from the library dependencies by the refactoring out of the debug/admin command line tool in #200; I think this can be closed now.

@estesp estesp closed this Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants