Skip to content

Use staging k8s.io/kubelet/cri/streaming package #9254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mxpv merged 1 commit into from
Oct 19, 2023
Merged

Use staging k8s.io/kubelet/cri/streaming package #9254

mxpv merged 1 commit into from
Oct 19, 2023

Conversation

@adisky
Copy link
Contributor

@adisky adisky commented Oct 17, 2023 •
edited
Loading

cri streaming package from kubelet moved to k8 staging so that it can be used by container runtime
kubernetes/kubernetes#118253

This PR removes the containerd own package and use the K8s staging one

@k8s-ci-robot
Copy link

k8s-ci-robot commented Oct 17, 2023

Hi @adisky. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adisky adisky force-pushed the cri-streaming-from-k8s branch 2 times, most recently from 22a2277 to ccd18e9 Compare October 17, 2023 09:44
@adisky
Use cri streaming pkg from k8s staging
03d81f5 
Use staging k8s.io/kubelet/cri/streaming package

Signed-off-by: Aditi Sharma <adi.sky17@gmail.com>
@adisky adisky force-pushed the cri-streaming-from-k8s branch from ccd18e9 to 03d81f5 Compare October 18, 2023 03:44
@estesp
Copy link
Member

estesp commented Oct 18, 2023

Interesting (positive) impact on k8s dependency imports in the diffstat: +7,628 −32,069!!

Looks like we get to drop api and api-server from containerd.

@estesp estesp requested a review from dims October 18, 2023 15:47
@estesp
Copy link
Member

estesp commented Oct 18, 2023

/ok-to-test

@samuelkarp samuelkarp added the area/cri Container Runtime Interface (CRI) label Oct 18, 2023
@mxpv mxpv merged commit f90f80d into containerd:main Oct 19, 2023
This was referenced Feb 23, 2024
Closed
Open
kiashok added a commit to kiashok/containerd that referenced this pull request Oct 23, 2024
@kiashok
Merged PR 8946463: [fork-external/main] Update fork-external/main wit…
ebe5b9b 
…h upstream containerd/main

update fork-external/main branch to upstream containerd/main at commit f90f80d

Related work items: containerd#8736, containerd#8861, containerd#8924, containerd#8934, containerd#9027, containerd#9076, containerd#9104, containerd#9118, containerd#9141, containerd#9155, containerd#9177, containerd#9183, containerd#9184, containerd#9186, containerd#9187, containerd#9191, containerd#9200, containerd#9205, containerd#9211, containerd#9214, containerd#9215, containerd#9221, containerd#9223, containerd#9228, containerd#9231, containerd#9234, containerd#9242, containerd#9246, containerd#9247, containerd#9251, containerd#9253, containerd#9254, containerd#9255, containerd#9268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@mxpv mxpv mxpv approved these changes

@estesp estesp estesp approved these changes

@dims dims Awaiting requested review from dims

Assignees

@mikebrow mikebrow

Labels

area/cri Container Runtime Interface (CRI) ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@adisky @k8s-ci-robot @estesp @samuelkarp @mxpv @mikebrow