[release/1.2] Prepare v1.2.13 release by thaJeztah · Pull Request #4033 · containerd/containerd

thaJeztah · 2020-02-17T10:31:33Z

depends on:

[release/1.2 backport] Fix container pid race condition #4025 [release/1.2 backport] Fix container pid race condition
[release/1.2] bump cgroups dependency to address blkio issue #4001 [release/1.2] bump cgroups dependency to address blkio issue
[release/1.2] backport: Set octet-stream content-type on put request #4028 [release/1.2] backport: Set octet-stream content-type on put request
[release/1.2 backport] Pin to libseccomp 2.3.3 #4015 [release/1.2 backport] Pin to libseccomp 2.3.3
[release/1.2 backport] Update Golang 1.12.17 #4031 [release/1.2 backport] Update Golang 1.12.17

The thirteenth patch release for containerd 1.2 fixes a regression introduced
in v1.2.12 that caused container/shim to hang on single core machines, fixes an
issue with blkio, and updates the Golang runtime to 1.12.17.

Notable Updates

Fix container pid race condition containerd#4025
Update containerd/cgroups dependency to address blkio issue containerd#4001
Set octet-stream content-type on PUT request containerd#4028
Pin to libseccomp 2.3.3 to preserve compatibility with hosts that do not have libseccomp 2.4 or up installed containerd#4015
Update Golang runtime to 1.12.17, which includes a fix to the runtime contrainerd#4031

thaJeztah · 2020-02-17T10:32:18Z

Generated release notes ~~(incomplete, because dependent PR's haven't been merged yet)~~;

containerd 1.2.13

Welcome to the v1.2.13 release of containerd!

The thirteenth patch release for containerd 1.2 fixes a regression introduced
in v1.2.12 that caused container/shim to hang on single core machines, fixes an
issue with blkio, and updates the Golang runtime to 1.12.17.

Notable Updates

Fix container pid race condition containerd#4025
Update containerd/cgroups dependency to address blkio issue containerd#4001
Set octet-stream content-type on PUT request containerd#4028
Pin to libseccomp 2.3.3 to preserve compatibility with hosts that do not have libseccomp 2.4 or higher installed containerd#4015
Update Golang runtime to 1.12.17, which includes a fix to the runtime containerd#4031

Please try out the release binaries and report any issues at
https://github.com/containerd/containerd/issues.

Contributors

Phil Estes
Wei Fu
Michael Crosby
Sebastiaan van Stijn
Gábor Lipták
Cao Zhihao
Ji'an Liu
Josh Dolitsky
Lantao Liu
Laurent Bernaille
Odin Ugedal
Su Fei
jiangpengfei

Changes

f141d0f7a Prepare v1.2.13 release
0c10aca55 Update .mailmap with changes from master
b9b4fa7f1 Merge pull request #4025 from thaJeztah/1.2_backport_fix_container_pid
1f6ea50be Merge pull request #4028 from estesp/cp-1.2-4017
b97098762 Fix container pid.
567ca6785 Set octet-stream content-type on put request
89c46ed57 Merge pull request #4035 from fuweid/cp12-246a560e
c9524284e Merge pull request #4031 from thaJeztah/1.2_bump_golang_1.12.17
28eb964b0 script: use github.com/kubernetes-sigs/cri-tools directly
5bead4582 Merge pull request #4001 from DataDog/lbernail/upgrade-cgroups
01edb7cdd Merge pull request #4015 from hakman/fix-libseccomp-ver
2a0ca2d07 Update Golang 1.12.17
a7c9b7605 Fix incorrect comment from copy/paste of starting script
6ad255383 Pin to libseccomp 2.3.3
25a806c50 bump cgroups dependency to address blkio issue

Changes from containerd/cgroups

c4b9ac5 Merge pull request #93 from sofat1989/master
f627015 avoid adding io_serviced and io_service_bytes duplicately
d596c78 Merge pull request #92 from lgtczh/add_mem_soft_limit
b589cd9 Merge pull request #90 from crosbymichael/makefile
13a3ac4 fixed an issue with invalid soft memory limits
215221e Add makefile for go and protos
db27230 Merge pull request #88 from woshijpf/fix-cgroup-left-problem
0ecd2b6 cgroups: fix MoveTo function fail problem
51b62d3 Merge pull request #86 from gliptak/import1
42091f5 Merge pull request #85 from odinuge/cgroups-hugetlb-fix
97bda9c Merge pull request #84 from gliptak/patch-2
38dc3ac Correct forked Travis builds
a9a304a Add Go 1.12 to Travis
51dcf5f Fix cgroup hugetlb size prefix for kB
fc51a4c Merge pull request #81 from ZeroMagic/add_network_stats
1741ae0 add network stats

Dependency Changes

Previous release can be found at v1.2.12

github.com/containerd/cgroups 4994991 -> c4b9ac5

codecov-io · 2020-02-17T11:43:43Z

Codecov Report

Merging #4033 into release/1.2 will increase coverage by 3.67%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/1.2    #4033      +/-   ##
===============================================
+ Coverage        44.19%   47.87%   +3.67%     
===============================================
  Files              100       91       -9     
  Lines            10847     8483    -2364     
===============================================
- Hits              4794     4061     -733     
+ Misses            5313     3688    -1625     
+ Partials           740      734       -6

Flag	Coverage Δ
#linux	`47.87% <ø> (ø)`	⬆️
#windows	`?`

Impacted Files	Coverage Δ
remotes/docker/auth.go	`63.82% <0%> (-3.97%)`	⬇️
remotes/docker/status.go	`21.42% <0%> (-3.58%)`	⬇️
platforms/cpuinfo.go	`3.77% <0%> (-0.85%)`	⬇️
log/context.go	`36.84% <0%> (-0.66%)`	⬇️
namespaces/context.go	`55% <0%> (-0.56%)`	⬇️
errdefs/grpc.go	`74.6% <0%> (-0.4%)`	⬇️
remotes/docker/pusher.go	`0% <0%> (ø)`	⬆️
content/local/locks.go	`100% <0%> (ø)`	⬆️
labels/validate.go	`100% <0%> (ø)`	⬆️
platforms/defaults.go	`100% <0%> (ø)`	⬆️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35bd7a5...9a517f6. Read the comment docs.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah · 2020-02-18T09:32:45Z

Rebased, updated mailmap, and updated the generated release notes above #4033 (comment)

@dmcgowan @estesp @mikebrow @fuweid @Random-Liu this should be ready for review

releases/v1.2.13.toml

estesp · 2020-02-18T14:41:48Z

Found a couple really minor typos, but we might as well fix

The thirteenth patch release for `containerd` 1.2 fixes a regression introduced in v1.2.12 that caused container/shim to hang on single core machines, fixes an issue with blkio, and updates the Golang runtime to 1.12.17. Notable Updates ---------------------------------- * Fix container pid race condition [containerd#4025](containerd#4025) * Update containerd/cgroups dependency to address blkio issue [containerd#4001](containerd#4001) * Set octet-stream content-type on PUT request [containerd#4028](containerd#4028) * Pin to libseccomp 2.3.3 to preserve compatibility with hosts that do not have libseccomp 2.4 or higher installed [containerd#4015](containerd#4015) * Update Golang runtime to 1.12.17, which includes a fix to the runtime [containerd#4031](containerd#4031) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah · 2020-02-18T15:32:06Z

Thanks @estesp - fixed the nits 👍

I noticed that the last part of the generated Markdown is a bit confusing:

Dependency Changes

Previous release can be found at v1.2.12

github.com/containerd/cgroups 4994991 -> c4b9ac5

Wondering if "previous release can be found at..." should be after the dependency change

thaJeztah · 2020-02-18T15:38:07Z

Opened containerd/release-tool#9 for the above

mikebrow

LGTM
Nits addressed.

estesp

LGTM

dmcgowan

LGTM

thaJeztah mentioned this pull request Feb 17, 2020

release 1.2.13-1 docker/containerd-packaging#135

Merged

Update .mailmap with changes from master

0c10aca

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah force-pushed the release_1.2.13 branch from 9a517f6 to bd32c5c Compare February 18, 2020 09:28

thaJeztah marked this pull request as ready for review February 18, 2020 09:30

thaJeztah requested review from dmcgowan and estesp February 18, 2020 09:32

thaJeztah mentioned this pull request Feb 18, 2020

[19.03] Update Golang 1.12.17 moby/moby#40533

Merged

estesp reviewed Feb 18, 2020

View reviewed changes

releases/v1.2.13.toml Outdated Show resolved Hide resolved

estesp reviewed Feb 18, 2020

View reviewed changes

releases/v1.2.13.toml Outdated Show resolved Hide resolved

thaJeztah force-pushed the release_1.2.13 branch from bd32c5c to 9efd13d Compare February 18, 2020 15:27

thaJeztah force-pushed the release_1.2.13 branch from 9efd13d to f141d0f Compare February 18, 2020 15:28

thaJeztah mentioned this pull request Feb 18, 2020

Move "previous release" link to the end containerd/release-tool#9

Merged

mikebrow approved these changes Feb 18, 2020

View reviewed changes

estesp approved these changes Feb 18, 2020

View reviewed changes

dmcgowan approved these changes Feb 18, 2020

View reviewed changes

dmcgowan merged commit 7ad1843 into containerd:release/1.2 Feb 18, 2020

thaJeztah deleted the release_1.2.13 branch February 18, 2020 19:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/1.2] Prepare v1.2.13 release#4033

[release/1.2] Prepare v1.2.13 release#4033
dmcgowan merged 2 commits intocontainerd:release/1.2from
thaJeztah:release_1.2.13

thaJeztah commented Feb 17, 2020 •

edited by fuweid

Loading

Uh oh!

thaJeztah commented Feb 17, 2020 •

edited

Loading

Uh oh!

codecov-io commented Feb 17, 2020

Uh oh!

thaJeztah commented Feb 18, 2020

Uh oh!

Uh oh!

Uh oh!

estesp commented Feb 18, 2020

Uh oh!

thaJeztah commented Feb 18, 2020

Dependency Changes

Uh oh!

thaJeztah commented Feb 18, 2020

Uh oh!

mikebrow left a comment

Uh oh!

estesp left a comment

Uh oh!

dmcgowan left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

thaJeztah commented Feb 17, 2020 • edited by fuweid Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notable Updates

Uh oh!

thaJeztah commented Feb 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notable Updates

Contributors

Changes

Changes from containerd/cgroups

Dependency Changes

Uh oh!

codecov-io commented Feb 17, 2020

Codecov Report

Uh oh!

thaJeztah commented Feb 18, 2020

Uh oh!

Uh oh!

Uh oh!

estesp commented Feb 18, 2020

Uh oh!

thaJeztah commented Feb 18, 2020

Dependency Changes

Uh oh!

thaJeztah commented Feb 18, 2020

Uh oh!

mikebrow left a comment

Choose a reason for hiding this comment

Uh oh!

estesp left a comment

Choose a reason for hiding this comment

Uh oh!

dmcgowan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thaJeztah commented Feb 17, 2020 •

edited by fuweid

Loading

thaJeztah commented Feb 17, 2020 •

edited

Loading