Skip to content

Add makefile for go and protos#90

Merged
fuweid merged 1 commit intocontainerd:masterfrom
crosbymichael:makefile
Jul 10, 2019
Merged

Add makefile for go and protos#90
fuweid merged 1 commit intocontainerd:masterfrom
crosbymichael:makefile

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Closes #87

Signed-off-by: Michael Crosby crosbymichael@gmail.com

Closes containerd#87

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 21, 2019

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   14.06%   14.06%           
=======================================
  Files          24       24           
  Lines        4907     4907           
=======================================
  Hits          690      690           
  Misses       4093     4093           
  Partials      124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db27230...215221e. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit b589cd9 into containerd:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

provide build metrics.proto guide in README?

4 participants