Skip to content

Add Go 1.12 to Travis#84

Merged
estesp merged 1 commit intocontainerd:masterfrom
gliptak:patch-2
Jun 3, 2019
Merged

Add Go 1.12 to Travis#84
estesp merged 1 commit intocontainerd:masterfrom
gliptak:patch-2

Conversation

@gliptak
Copy link
Copy Markdown
Contributor

@gliptak gliptak commented May 30, 2019

No description provided.

@estesp
Copy link
Copy Markdown
Member

estesp commented May 31, 2019

Needs a Signed-off-by: on the commit; also, let's drop Go 1.10 when we add 1.12.

Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 31, 2019

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   14.06%   14.06%           
=======================================
  Files          24       24           
  Lines        4905     4905           
=======================================
  Hits          690      690           
  Misses       4091     4091           
  Partials      124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc51a4c...a9a304a. Read the comment docs.

@gliptak
Copy link
Copy Markdown
Contributor Author

gliptak commented May 31, 2019

@estesp updated

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 97bda9c into containerd:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants